Date: Tue, 22 Aug 2000 20:26:53 +0200 From: "Eli Zaretskii" Sender: halo1 AT zahav DOT net DOT il To: lauras AT softhome DOT net Message-Id: <3995-Tue22Aug2000202653+0300-eliz@is.elta.co.il> X-Mailer: Emacs 20.6 (via feedmail 8.2.emacs20_6 I) and Blat ver 1.8.5b CC: djgpp-workers AT delorie DOT com In-reply-to: <39A275AD.31F59BA0@softhome.net> (message from Laurynas Biveinis on Tue, 22 Aug 2000 14:44:29 +0200) Subject: Re: Patch: symlinks in _dxe_load() References: <39A275AD DOT 31F59BA0 AT softhome DOT net> Reply-To: djgpp-workers AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: djgpp-workers AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk > Date: Tue, 22 Aug 2000 14:44:29 +0200 > From: Laurynas Biveinis > > One > thing I've found that _dxe_load is using _open(). IMHO open() > does better with symlinks. Change tested, it works. Hmm.. I'm not sure this is a good idea. _dxe_load was meant to be as small as possible. Why does it need to support symlinks? (And, btw: if you replace _open with open, you need to use O_BINARY, since that's how _open opens the file. I'm guessing that it worked for you by sheer luck--no ^Z characters in the DXE, etc.)