Date: Fri, 18 Aug 2000 08:27:23 +0300 (IDT)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender: eliz AT is
To: Laurynas Biveinis <lauras AT softhome DOT net>
cc: DJGPP Workers <djgpp-workers AT delorie DOT com>
Subject: Re: Patch: FSEXT nits for stat()/lstat()
In-Reply-To: <399C178E.E9B73BA2@softhome.net>
Message-ID: <Pine.SUN.3.91.1000818082329.29393E@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


On Thu, 17 Aug 2000, Laurynas Biveinis wrote:

> When I've moved most code from stat() to lstat(), FSEXT hook
> has been moved too. However, its name __FSEXT_stat is misleading
> now, because it actually should be __FSEXT_lstat. Simple switch
> is impossible due to backwards compatibility (sounds like a curse ;),
> so I have added simple #define __FSEXT_lstat __FSEXT_stat in header,
> and updated docs to refer to __FSEXT_lstat.

I don't see any problems with #define, but I also don't see any problems 
with staying with the old name.  It's not a problem if an FSEXT hook has 
a name that isn't 100% identical to the exact function where it is called.

For example, __FSEXT_open is called from _open, not from open.

> BTW, I was surprised: fsext.txh did not contain documentation for
> __FSEXT_stat. I bet it didn't for 5 years ;).

Not 5 years: __FSEXT_stat was added only in v2.02.

> I've added that too.

Thanks.