From: "Juan Manuel Guerrero" Organization: Darmstadt University of Technology To: eliz AT is DOT elta DOT co DOT il Date: Tue, 15 Aug 2000 16:21:01 +0200 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Subject: Re: small patch for unzip32 CC: djgpp-workers AT delorie DOT com X-mailer: Pegasus Mail for Windows (v2.54DE) Message-ID: Reply-To: djgpp-workers AT delorie DOT com Date: Tue, 15 Aug 2000 15:10:26 +0200 From: "Eli Zaretskii" > > Comments, suggestions, etc are welcome before a send a similar patch > > to the InfoZip maintainers. > > About this change: > > > + # ifndef __DJGPP__ > > + /* > > + This is DJGPP specific: > > + TZ is usualy not defined in the AUTOEXEC.BAT of an average user. > > + Issueing continuously this warning may confuse most of the newbies. > > + All this means: > > + check for TZ, use it if available but do not complain if not available. > > + */ > > Info(slide, 0x401, ((char *)slide, LoadFarString(WarnInvalidTZ))); > > + # endif > > I agree that it is a good idea to disable the warning for unzip32.exe > that is uploaded to SimTel.NET, but I don't think you should send this > change to the UnZip maintainers. In general, the warning that's > printed here is a valuable one, and should IMHO be kept. Yes, I agree. Please note, the patch I have submitted is **not** the patch I will submit to the InfoZip maintainers. The patch I send is for information of the djgpp workers and that is the one I will use to replace the unzip32.exe at SimTel.NET. That was the reason why I wrote I would send a **similar** but not the same patch to InfoZip maintainers. Of course, the above change is 100% DJGPP specific and will **not** be submitted to the maintainers. Netherless, thanks for the advise. Regards, Guerrero, Juan Manuel