Date: Tue, 15 Aug 2000 15:18:56 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: lauras AT softhome DOT net
Message-Id: <4634-Tue15Aug2000151854+0300-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.2.emacs20_6 I) and Blat ver 1.8.5b
CC: djgpp-workers AT delorie DOT com
In-reply-to: <39991815.18D22ABE@softhome.net> (message from Laurynas Biveinis
	on Tue, 15 Aug 2000 12:14:45 +0200)
Subject: Re: Patch: lstat() adjustments for symlinks
References: <399844B1 DOT 9A99D08F AT softhome DOT net> <9743-Tue15Aug2000085950+0300-eliz AT is DOT elta DOT co DOT il> <39991815 DOT 18D22ABE AT softhome DOT net>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Tue, 15 Aug 2000 12:14:45 +0200
> From: Laurynas Biveinis <lauras AT softhome DOT net>
> 
> Maybe rewriting the whole thing like follows would be better?
> 
> @cindex Symlink support AT r{, new functions}
> @findex __solve_symlinks AT r{, added to library}
> @findex lstat AT r{, added to library}
> @findex readlink AT r{, added to library}
> ...
> 
> @cindex Symlink support AT r{, adjusted functions}
> @findex symlink AT r{, changed behaviour}
> ...

Yes, this is also okay, but: the common "Symlink support" entry will
require you to put all functions in that category together; if you, or
someone else, forgets, the users lose.

If you think that index entries such as "Symlink support..."  are
useful on their own right, perhaps it would be better to add a
paragraph that talks only about the fact that symlinks are supported,
and have this @cindex entry point to that paragraph.  You may put
@xref's there to the docs of the relevant functions in libc.info.

One other comment: index entries should be in lower case (unless you
are indexing an acronym, such as ASCII).  Recall how the index is
printed in a book: the entries usually begin with a lower-case letter.

> > Unless you have a good reason for this lack of a newline, please add
> > one.  
> 
> OK I'll add it there. Note that testsuite data files intentionally do not 
> contain ending newlines and I add them to CVS as binary files.

Sure, I saw that.  My comment was only about the source of the test
program.