Date: Tue, 15 Aug 2000 15:10:26 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: ST001906 AT HRZ1 DOT HRZ DOT TU-Darmstadt DOT De
Message-Id: <4331-Tue15Aug2000151024+0300-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.2.emacs20_6 I) and Blat ver 1.8.5b
CC: djgpp-workers AT delorie DOT com
In-reply-to: <C72A0C6365E@HRZ1.hrz.tu-darmstadt.de>
	(ST001906 AT HRZ1 DOT HRZ DOT TU-Darmstadt DOT De)
Subject: Re: small patch for unzip32
References:  <C72A0C6365E AT HRZ1 DOT hrz DOT tu-darmstadt DOT de>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: "Juan Manuel Guerrero" <ST001906 AT HRZ1 DOT HRZ DOT TU-Darmstadt DOT De>
> Date: Tue, 15 Aug 2000 12:33:53 +0200
> 
> The patch is based on unzip 5.41 (latest stable release). I have
> used this modified version for a month and i had no difficulties.
> I have compiled the package, compressed the coff image with upx
> and bound it with PMODE. If this new binary is wanted, let me know
> and i will upload it to simtel.

I think you should upload it.  Thanks for working on this.

> Comments, suggestions, etc are welcome before a send a similar patch
> to the InfoZip maintainers.

About this change:

> + #   ifndef __DJGPP__
> +      /*
> +         This is DJGPP specific:
> +         TZ is usualy not defined in the AUTOEXEC.BAT of an average user.
> +         Issueing continuously this warning may confuse most of the newbies.
> +         All this means:
> +         check for TZ, use it if available but do not complain if not available.
> +      */
>               Info(slide, 0x401, ((char *)slide, LoadFarString(WarnInvalidTZ)));
> + #   endif

I agree that it is a good idea to disable the warning for unzip32.exe
that is uploaded to SimTel.NET, but I don't think you should send this
change to the UnZip maintainers.  In general, the warning that's
printed here is a valuable one, and should IMHO be kept.