Message-ID: <39951E9F.EE95167F@softhome.net>
Date: Sat, 12 Aug 2000 11:53:35 +0200
From: Laurynas Biveinis <lauras AT softhome DOT net>
X-Mailer: Mozilla 4.74 [en] (Win98; U)
X-Accept-Language: lt,en
MIME-Version: 1.0
To: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
CC: djgpp-workers AT delorie DOT com
Subject: Re: Patch: symlink()
References: <39941478 DOT 329CA50B AT softhome DOT net> <md5:9354A621B2BE266AAD94DB6B17E87353>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

eliz AT is DOT elta DOT co DOT il wrote:
> You should not leave a space between "---" and the following word,
> because it will look wrong in the output if the formatting breaks the
> line in another place.  

OK, fixed there and elsewhere.

> Please leave 2 blanks after the dot which ends a sentence (here and
> elsewhere).

OK, fixed everywhere I've noticed that.

> > -  /* Allow to say `ln -s src dest' when we really
> > -     mean `src.exe' and `dest.exe'  */
> 
> Should we support this feature of the previous implementation?

IMHO we should: backwards compatibility, UNIX stuff compatibility...
I'll add it when core symlink support works.

> Didn't your patches add files test1 and test2, not fail1 and fail2?

They added both, total of 2 directories and 15 files.

> Also, perhaps it's better to name the missing files in the error
> message, so that the luser will know what files to look for.

Current UI of testsuite forces to use code anyway. For example, if you get

Test 11 failed - unexpected __solve_symlinks() success

you have to look at code anyway to determine *what* is wrong. IMHO
error reporting in both cases could be adjusted later.

Thanks for help,
Laurynas