Message-Id: <200008120659.CAA08739@delorie.com>
Date: Sat, 12 Aug 2000 10:01:53 +0200
To: lauras AT softhome DOT net
X-Mailer: Emacs 20.6 (via feedmail 8.2.emacs20_6 I) and Blat ver 1.8.5b
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
CC: djgpp-workers AT delorie DOT com
In-reply-to: <39941478.329CA50B@softhome.net> (message from Laurynas Biveinis
	on Fri, 11 Aug 2000 16:58:00 +0200)
Subject: Re: Patch: symlink()
References:  <39941478 DOT 329CA50B AT softhome DOT net>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Fri, 11 Aug 2000 16:58:00 +0200
> From: Laurynas Biveinis <lauras AT softhome DOT net>
> 
> Feedback appreciated,
[snip]
> +@subheading Description
> +DOS does not support symbolic links. However, DJGPP emulates them---
> +this function creates a file with special size and format, so other

You should not leave a space between "---" and the following word,
because it will look wrong in the output if the formatting breaks the
line in another place.  Here's an example of how it could look:

      However, DJGPP emulates them-- this function creates...

> +DJGPP library functions transparently work with file which is pointed to
> +by symlink. Of course, it does not work outside DJGPP programs. Those
> +library functions which are simple wrappers about DOS calls do not
> +use symlinks neither.

Please leave 2 blanks after the dot which ends a sentence (here and
elsewhere).

> -  /* Allow to say `ln -s src dest' when we really
> -     mean `src.exe' and `dest.exe'  */

Should we support this feature of the previous implementation?
(You don't need to delay the commit even if you think we should
support this; it can be added later.)

> +   if (!__file_exists("fail1") || !__file_exists("fail2"))
> +   {
> +      fprintf(stderr, "Cannot run testsuite - required data files not found\n");
> +      exit(1);

Didn't your patches add files test1 and test2, not fail1 and fail2?

Also, perhaps it's better to name the missing files in the error
message, so that the luser will know what files to look for.