Message-Id: <200008111012.GAA18090@delorie.com>
Date: Fri, 11 Aug 2000 12:47:03 +0200
To: tr AT eth DOT net
X-Mailer: Emacs 20.6 (via feedmail 8.2.emacs20_6 I) and Blat ver 1.8.5b
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
CC: djgpp-workers AT delorie DOT com
In-reply-to: <Pine.LNX.4.21.0007250651010.823-100000@midpec.com> (message from
	Prashant TR on Tue, 25 Jul 2000 06:59:03 +0530 (IST))
Subject: Re: Sh-utils 2.0j sources uploaded
References:  <Pine DOT LNX DOT 4 DOT 21 DOT 0007250651010 DOT 823-100000 AT midpec DOT com>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Tue, 25 Jul 2000 06:59:03 +0530 (IST)
> From: Prashant TR <tr AT eth DOT net>
> 
> 1> I've added some macros to src/system.h to make the code look more
> clean. Could someone please have a look at this and tell me if they're
> fine.

The macros look good.  ISSLASH is not defined except under __MSDOS__;
won't this cause trouble on Unix?

> 2> djgpp/config.bat edits the makefiles individually. I've added the
> necessary sed scripts for this but for some reason they don't edit the
> makefiles.

I couldn't figure out what parts exactly didn't work, and what did you
do to work around that.  Can you please identify the guilty parties?

> These are the final set of patches I'll be sending to the Sh-utils
> maintainer, so any coments are highly appreciated.

I have a few comments (beyond those I send in a separate mail):

The DJGPP-specific fragment in tee.c which sets mode_string to "ab" or
"wb", should, I think be replaced by a SET_BINARY call on the file
descriptor returned by `fopen'.  I think Jim Meyering explicitly
requested that.

The following patch gets the MSDOS-specific part backwards:

    --- old/sh-utils-2.0j/src/su.c	Sat May  6 14:17:20 2000
    +++ sh-utils-2.0j/src/su.c	Sat Jul 22 21:01:54 2000
    @@ -128,7 +128,11 @@
     #ifdef _PATH_DEFPATH
     # define DEFAULT_LOGIN_PATH _PATH_DEFPATH
     #else
    -# define DEFAULT_LOGIN_PATH ":/usr/ucb:/bin:/usr/bin"
    +# ifdef MSDOS
    +#  define DEFAULT_LOGIN_PATH ":/usr/ucb:/bin:/usr/bin"
    +# else
    +#  define DEFAULT_LOGIN_PATH "c:/dos;c:/windows;c:/"
    +#endif
     #endif

About the value of default_shells[] in getusershell.c: perhaps instead
of the environment variable (which Jim Meyering didn't like), it's
better to (1) add "/dev/env/DJDIR/bin/bash.exe" to the list, and (2)
define SHELLS_FILE to "/dev/env/DJDIR/etc/shells" (and add an empty
file to the binary distro), so that users could add/edit that file if
their shell isn't in the list.