Message-Id: <200008081734.NAA03315@delorie.com>
Date: Tue, 08 Aug 2000 19:51:17 +0200
To: bkorb AT gnu DOT org
X-Mailer: Emacs 20.6 (via feedmail 8.2.emacs20_6 I) and Blat ver 1.8.5b
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
CC: djgpp-workers AT delorie DOT com
In-reply-to: <399031D7.6FF8F2E1@sco.com> (message from Bruce Korb on Tue, 08
	Aug 2000 09:14:15 -0700)
Subject: Re: DJGPP patch for fixincludes
References: <Pine DOT SUN DOT 3 DOT 91 DOT 1000808092918 DOT 4905A-100000 AT is> <399031D7 DOT 6FF8F2E1 AT sco DOT com>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Tue, 08 Aug 2000 09:14:15 -0700
> From: Bruce Korb <bkorb AT sco DOT COM>
> 
> > > I think it safe to assume that ``system(3)'' will work essentially
> > > the same way on UNIX and DOS.
> > 
> > That is not a very good assumption, although when $SHELL points to
> > Bash, the similarity is almost 100%, because in that case, DJGPP's
> > system(3) simply invokes Bash with its unmodified argument.
> 
> Well, then if they do not have Bash installed, it is entirely possible
> that fixincl will not run.

That's true, but that is not a real problem in this case: the GCC
build procedure for DJGPP *requires* Bash (and quite a few of other
GNU tools, like Fileutils, Grep, Sed, etc.).  So we can safely assume
that Bash is available; and mkfixincl.sh actually takes care of
setting $SHELL explicitly before it runs "make -f Makefile.DOS".

> As long as ``system(3)'' can correctly handle this style of quoting:
> 
>   sed -e 's/'\''/"/'

It does handle this correctly, even without Bash.  But without Bash,
the backslash only quotes an apostrophe or a quote (since a backslash
is a directory separator).  However, this is not a problem in this
case, I only mentioned the issue btw.

>     sed = "/^\tstrncmp(),$/N";
>     sed = 's/^\(' "\t" 'strncmp()\),\n\(' "\t" 'strlen(),\)$/'
>             '\1;' "\\\nextern unsigned int\\\n\\2/";
> 
> If you can fix that one, it would be wonderful  :-).

I will see what I can do.

> The missing NULL define is a problem, however.
> That needs to be run down.

Okay, I will look into this.  Thanks for the hints.