Sender: bkorb AT sco DOT COM
Message-ID: <398ED65F.52CF62FA@sco.com>
Date: Mon, 07 Aug 2000 08:31:43 -0700
From: Bruce Korb <bkorb AT sco DOT COM>
Organization: Santa Cruz Operations
X-Mailer: Mozilla 4.7 [en] (X11; I; SCO_SV 3.2 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
CC: djgpp-workers AT delorie DOT com, Bruce Korb <bkorb AT gnu DOT org>
Subject: Re: DJGPP patch for fixincludes
References: <Pine DOT SUN DOT 3 DOT 91 DOT 1000806094650 DOT 14058C-100000 AT is>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com


Hi Eli,

Thanks for all your work!  I will be integrating it over the
next week or so (this _is_ a play time activity ;-).
A couple of little nits tho.  See below.

Regards,
	Bruce

Eli Zaretskii wrote:
> 
> On Sun, 30 Jul 2000, Bruce Korb wrote:
> 
> > 3.  check.tpl should be augmented so that after the regular fixincl
> >     goes through its paces, the __MSDOS__ flavor is built and run
> >     against the one header, "testing.h".  Test that the output is
> >     correct.  That should test the operation of the DOS  version.
> >     That ought to be enough.
> 
> It was enough to find another bug in the DJGPP version of fixincl: the
> external fixes didn't work because I failed to consider the
> possibility that the input and the output files are the same file.  So
> redirection nuked the input before the program got a chance to look at
> it.

That was why I originally had all that mumbo-jumbo with *three* different
file names:  the original file, the temporary file and the temporary
temporary ;-) that got renamed on top of the less-temporary temporary.
Your solution is to let bash do all that.  Fine.  Whatever works.  :-)

As for your other patch, I am going to disable the file name test
disablement.  It is not really necessary for the "make check" to
run on DOS.  I think it safe to assume that ``system(3)'' will work
essentially the same way on UNIX and DOS.  Therefore, I just want to
be able to test that the DOS mechanism (of avoiding ``fork(2)'' and
``exec(2)'') is still working.  (By the way, if ``pz_machine'' is NULL,
then fixincl is operating in test mode.)  Also, the file:

  "fixinc/tests/msdos/testing.exp"

should be identical to the file "fixinc/tests/base/testing.h",
or I would like to know why they should be different.