Message-ID: <397FFFEF.7CE81083@softhome.net>
Date: Thu, 27 Jul 2000 11:25:03 +0200
From: Laurynas Biveinis <lauras AT softhome DOT net>
X-Mailer: Mozilla 4.73 [en] (Win98; U)
X-Accept-Language: lt,en
MIME-Version: 1.0
To: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
CC: djgpp-workers AT delorie DOT com
Subject: Re: Patch: lchown()
References: <Pine DOT SUN DOT 3 DOT 91 DOT 1000727085401 DOT 18864B-100000 AT is>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Eli Zaretskii wrote:
>   - You need to set errno value to zero before calling a library
>     function, if you want to test errno afterwards.  Otherwise, the
>     value of errno might be from the wrong call.

Right.

>   - It's usually best to test a file-related function on a variety of
>     different file types: an ordinary file, a directory, a root
>     directory (it's not a file on FAT filesystems), a character
>     device, and a volume label.  

Why only character device? All devices are chownable.

> Whether this is justified for a
> trivial function such as `lchown', is up to you ;-).

Will see, as always.

Another thing is that chown() will become less trivial with
symlink support. But I'm thinking about having separate tests
for internal core function for symlink resolving and do not put
this kind of tests for a dozen of user functions.

> > +This function does nothing under MS-DOS
> 
> There should be a period at the end of this sentence.

It comes from original chown.txh. I've fixed it in both places.

Laurynas