Date: Thu, 29 Jun 2000 09:58:56 +0300 (IDT) From: Eli Zaretskii X-Sender: eliz AT is To: Laurynas Biveinis cc: djgpp-workers AT delorie DOT com Subject: Re: libc/stubs business In-Reply-To: <395A46EC.5171DC14@softhome.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Reply-To: djgpp-workers AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: djgpp-workers AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On Wed, 28 Jun 2000, Laurynas Biveinis wrote: > Eli Zaretskii wrote: > > Yes. But this doesn't fix the tempnam problem, does it? > > Hm? The following part of that patch doesn't? > > Index: djgpp/src/libc/compat/stdio/tempnam.c > =================================================================== > RCS file: /cvs/djgpp/djgpp/src/libc/compat/stdio/tempnam.c,v > retrieving revision 1.2 > diff -u -r1.2 tempnam.c > --- tempnam.c 1997/10/28 19:22:12 1.2 > +++ tempnam.c 2000/06/28 08:31:01 > @@ -1,5 +1,7 @@ > +/* Copyright (C) 2000 DJ Delorie, see COPYING.DJ for details */ > /* Copyright (C) 1997 DJ Delorie, see COPYING.DJ for details */ > /* Copyright (C) 1995 DJ Delorie, see COPYING.DJ for details */ > +#include Sorry, I missed the patch to tempnam.c (I only remember seeing the patch for fsext.c). > > I don't think this is a test. It is no more a test than the fact that we > > use a lot of -W* switches, to reveal possible bugs. I think that > > polluting ANSI/Posix namespace is a grave problem, and if an automated > > tool finds quite a few problems, even after several cleanup efforts, it's > > a clear sign that manual procedures are inadequate. > > I wonder if anyone has reported this grave problem in 2.03 ;-) I don't remember any such reports, and I didn't know about libclink/check until DJ mentioned it in this thread. So I never ran that utility during v2.03 development. All the stubs-related cleanups were a result of manual inspection.