Date: Wed, 14 Jun 2000 12:19:24 +0300 (IDT) From: Eli Zaretskii X-Sender: eliz AT is To: Prashant TR cc: djgpp-workers AT delorie DOT com Subject: Re: Patches for FSDB to look for .exe files In-Reply-To: <200006131609.VAA04537@midpec.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Reply-To: djgpp-workers AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: djgpp-workers AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On Tue, 13 Jun 2000, Prashant TR wrote: > > This is IMHO not robust enough: the file could exist, but be a > > directory, or something that is not a DJGPP program. I suggest using > > _check_v2_prog instead of __file_exists. > > > > Please also provide a short entry for wc204.txi. > > Changed. Does it look better now? Yes, thanks. I have only 2 minor comments: > +@findex fsdb, check for EXEs It's better to write this like so: @findex fsdb AT r{, check for .EXE extension} The @r thing cause everything except "fsdb" to be typeset in the normal Roman font. This is better because the default markup for @findex entries is @code, which cause a monotype font to be used. > +@code{fsdb} checks for executables and loads them even if > +the extension ``.EXE'' isn't given in the command line. File name or parts thereof should have the @file markup. Thus, @file{.exe} is a better way than ``.EXE''. Other than that, it's fine with me.