Date: Sun, 11 Jun 2000 17:38:12 -0400
Message-Id: <200006112138.RAA22842@envy.delorie.com>
From: DJ Delorie <dj AT delorie DOT com>
To: djgpp-workers AT delorie DOT com
In-reply-to: <3943BCD0.22771.2CF8D0@localhost> (snowball3@bigfoot.com)
Subject: Re: patch for _get_dev_info return bits
References:  <3943BCD0 DOT 22771 DOT 2CF8D0 AT localhost>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


> Several of the termios implementation files define _DEV_* macros to
> parse the dev info word returned by _get_dev_info. This patch
> deletes all these macros and defines them in just one place in
> <io.h> where the prototype for _get_dev_info is located. I noticed
> the large number of duplicates while working on the enhanced fcntl.

For cases like this you could create a header file right in with the
sources, rather than use a public header, unless we really want those
bits to be public.

> Also, should the _DEV_* macros be documented and extended to cover
> all the bits?

If you're going to put them in a public header, yes.