Date: Sun, 12 Dec 1999 13:36:09 +0200 (IST)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender: eliz AT is
To: Laurynas Biveinis <lauras AT softhome DOT net>
cc: DJGPP Workers <djgpp-workers AT delorie DOT com>
Subject: Re: 3rd symlink patch (resent)
In-Reply-To: <384FDE43.764FC4A@softhome.net>
Message-ID: <Pine.SUN.3.91.991212133551.19096H-100000@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: djgpp-workers AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


On Thu, 9 Dec 1999, Laurynas Biveinis wrote:

> The old one is with debug output enabled. That's not what I intend
> to put in library, please read this one. Sorry.

Thanks.  Only three minor comments this time:

> diff -u -r -N --minimal djgpp.old/src/libc/posix/sys/stat/stat.txh djgpp/src/libc/posix/sys/stat/stat.txh
> --- djgpp.old/src/libc/posix/sys/stat/stat.txh	Thu Jan  1 00:00:00 1970
> +++ djgpp/src/libc/posix/sys/stat/stat.txh	Thu Dec  9 17:45:30 1999
> @@ -0,0 +1,97 @@

There's something wrong here: this says that stat.txh didn't exist
before, which isn't true (so this patch will fail to apply).  I'm
guessing that you renamed stat.txh into lstat.txh, and then created a
new stat.txh.  Please rename the old stat.txh back, diff the new
stat.txh against that, and make lstat.txh be a new file.

> +This function fully resolves given symlink in @var{symlink_path} -

A dash should be written as "---" (yes, three dashes in a row).  This
is typeset (by TeX) as a slightly longer dash, which is what people
expect from a printed text.  Also, it is customary in English text to
leave no blanks between the words separated with a dash, like this:

      foo---bar

There is at least one more place in the patches where this should be
corrected.

> +@example
> +
> +  #include <libc/symlink.h>
> +
> +  if (!_solve_symlinks(fn, file_name))
> +     perror();

The call to `perror' isn't quite right here...