Message-Id: <m0zpXoO-000S57C@inti.gov.ar>
Comments: Authenticated sender is <salvador AT natacha DOT inti DOT gov DOT ar>
From: "Salvador Eduardo Tropea (SET)" <salvador AT inti DOT gov DOT ar>
Organization: INTI
To: Tim "Zastai" <zastai AT hotmail DOT com>, djgpp-workers AT delorie DOT com
Date: Mon, 14 Dec 1998 10:15:20 +0000
MIME-Version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Subject: Bugs in CVS 1.9 distributed in Simtelnet
X-mailer: Pegasus Mail for Windows (v2.54)
Reply-To: djgpp-workers AT delorie DOT com

Hi All:

  Last friday I was learning about CVS, this seems to be a very nice tool.
  Playing with it I found some bugs in the DOS port (they are bugs in the 
original too, at least from my point of view but affects DOS not Linux):

1) The import command imports the files using fopen(file,"r"); and for some
strange reason Tim used _fmode=O_BINARY; (I think because CVS have a lot of
bugs and in this way most of them are hided).
  Anyways that's a serious bug because then the text files are saved in the
repository with \r\n. I think that here CVS should check the mode and open
the file according it.
  I have a working patch for it that checks the mode and explicitly selects
"wb" or "wt" (no default assumptions for "w"=xxxx).

2) A similar bug affects the checkout process. In this case the _fmode makes
the CVS checks fail. CVS have it >(binary) ? "wb" : "w"< That's again a bug
in CVS that fails because the _fmode setting. I think it should be:
>(binary) ? "wb" : "wt"<. Is that correct? It works ok for djgpp of course.

  Even when my editor (and hence RHIDE) supports UNIX and DOS files these too
bugs produces problems when trying to share a repository with the UNIX
version of CVS (other problems than the usual ones, I think I'll need to 
patch the Linux version too ;-).
  Are djgpp workers using this tool? I think is much better than RCS but 
needs some options to be 100% usable.

SET
------------------------------------ 0 --------------------------------
Visit my home page: http://set-soft.home.ml.org/
or
http://www.geocities.com/SiliconValley/Vista/6552/
Salvador Eduardo Tropea (SET). (Electronics Engineer)
Alternative e-mail: set-soft AT usa DOT net set AT computer DOT org
ICQ: 2951574
Address: Curapaligue 2124, Caseros, 3 de Febrero
Buenos Aires, (1678), ARGENTINA
TE: +(541) 759 0013