Date: Tue, 24 Mar 1998 13:55:03 +0300 (IDT)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
To: Vik Heyndrickx <Vik DOT Heyndrickx AT rug DOT ac DOT be>
cc: DJGPP workers <djgpp-workers AT delorie DOT com>
Subject: Re: a faster memmove: patch for alpha-980101
In-Reply-To: <35161F31.2854@rug.ac.be>
Message-ID: <Pine.SUN.3.91.980324135432.22075K-100000@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Precedence: bulk


On Mon, 23 Mar 1998, Vik Heyndrickx wrote:

> The patchfile contains also an unrelated patch that causes the djlsr202
> sources not to compile successful with gcc-2.8.0 due to a new warning
> message.

Please do not lump together unrelated patches.  It is inconvenient if
for some reason DJ choses not to apply some of them.

> *** orig/src/libc/ansi/string/memmove.S	Tue Mar 28 09:14:46 1995
> --- mem.diff/src/libc/ansi/string/memmove.S	Sun Mar 22 22:42:40 1998
> ***************
> *** 1,33 ****
> ! /* Copyright (C) 1995 DJ Delorie, see COPYING.DJ for details */
> ! 	.file "memmove.s"
> ! 	.globl	_memmove
>   _memmove:
> ! 	pushl	%ebp
> ! 	movl	%esp,%ebp
> ! 	pushl	%esi
> ! 	pushl	%edi

This patch is 99.99% changes in indentation (probably because your
editor replaced TABS with spaces).  Please try to avoid doing this, as
it makes spotting the *real* differences very hard.

> ! /* Copyright (C) 1998 DJ Delorie, see COPYING.DJ for details */

The new Copyright line does not replace the old one, it is in addition
to the old one (put the new one before the old one).