Date: Tue, 27 Jan 1998 14:47:44 +0200 (IST)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
To: Randy Maas <randym AT acm DOT org>
cc: djgpp-workers AT delorie DOT com
Subject: Re: stat patch
In-Reply-To: <3.0.1.32.19980126152600.007f3d80@yacker.xiotech.com>
Message-ID: <Pine.SUN.3.91.980127144350.843C-100000@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Precedence: bulk


On Mon, 26 Jan 1998, Randy Maas wrote:

> Previously I had suggested that maybe opening the file and the
> fstat'ing it would be a good way to keep things simple.
> I've decided not to propose that

I agree that this is not a good idea, since it may fail due to
shortage of file handles.  Also, installing a handler for fstat (which
is a handle-based function) when you really want a handler based on a
file name is counter-intuitive.

> *** src\libc\posix\sys\stat\stat.c~1	Sun Nov 16 14:04:58 1997
> --- src\libc\posix\sys\stat\stat.c	Mon Jan 26 15:01:46 1998

You should *never* use backslashes in diffs, since people might apply
them on Unix machines, where it will fail miserably.

> + 
> +   if (__FSEXT_call_open_handlers(__FSEXT_stat, &ret, &path))
> +    return ret;

This doesn't pass `statbuf' to the handler.  How on earth is this
supposed to work?