Date: Tue, 13 Jan 1998 08:25:53 -0500 (EST)
Message-Id: <199801131325.IAA19701@delorie.com>
From: DJ Delorie <dj AT delorie DOT com>
To: Anthony DOT Appleyard AT umist DOT ac DOT uk
Cc: djgpp-workers AT delorie DOT com
In-reply-to: <25A7F473B51@fs2.mt.umist.ac.uk> (MCLSSAA2@fs2.mt.umist.ac.uk)
Subject: Re: MCLSSAA2 AT fs2 DOT mt DOT umist DOT ac DOT uk: Hooking interrupt 9 : amended
Precedence: bulk


>   extern int (*_djgpp_kbd_callback)(int X);  /* initial value == 0 */
> ///// This line should be inserted in some suitable #insert<***.h> file.

No, decide which file it goes in and supply a patch to put it there.

>   If _djgpp_kbd_callback is nonzero, the function that it points to is
> automatically called whenever a keyboard event occurs such as a key being
> pressed or released. When it is called:-
>      X     &255 == the keyboard event code
>     (X>> 8)&255 == keyboard shift status as if from (AH=2, int 16h)
>     (X>>16)&255 == keyboard extended shift status as if from (AH=12h, int 16h)

This is not the correct format for documentation.  You should supply a
patch (or new file) for the appropriate .txh file, in texinfo format,
with the same style as all the other .txh files.

>   enum{k_esc=1, k_1, k_2, k_3, k_4, k_5, k_6, k_7, k_8, k_9, k_0, k_1rof0,
> k_2rof0, k_backspace, k_tab, k_Q, k_W, k_E, k_R, k_T, k_Y, k_U, k_I, k_O, k_P,
> k_1rofP, k_2rofP, k_enter, k_lctrl, k_A, k_S, k_D, k_F, k_G, k_H, k_J, k_K,

This is unreadable.

> *** _ex.old	Mon Jan 12 14:54:06 1998
> --- _ex.s	Tue Jan 13 10:33:46 1998

Diffs should be made based on the *real* file names, else we can't
apply them.

> + CARRYON2:

Please follow the conventions already in place.  Use lower case for
labels just like all the other labels.