Message-ID: <3383F9E2.2513@cs.com>
Date: Thu, 22 May 1997 07:46:42 +0000
From: "John M. Aldrich" <fighteer AT cs DOT com>
Reply-To: fighteer AT cs DOT com
Organization: Two pounds of chaos and a pinch of salt
MIME-Version: 1.0
To: Robert Hoehne <robert DOT hoehne AT mathematik DOT tu-chemnitz DOT de>
CC: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>,
        DJGPP Workers Mailing List <djgpp-workers AT delorie DOT com>
Subject: Re: Bugfix for redir.c
References: <Pine DOT HPP DOT 3 DOT 95q DOT 970522125805 DOT 26457H-100000 AT newton DOT mathematik DOT tu-chemnitz DOT de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

Robert Hoehne wrote:
> 
> On Tue, 20 May 1997, Eli Zaretskii wrote:
> 
> > I don't think this is a good idea.  It might work (I didn't check yet),
> 
> I haven't checked it also not in all cases but I think it should
> work. It was only a try to reduce the patch. If you are not
> agree with it, also OK because it is not so important for
> me.

Even if it does work in all cases _now_, I would much rather redir be
patched with code that's guaranteed to work in all cases in the future. 
Hacking the internal code of the dosexec functions is absolutely
guaranteed to be nonportable.  OTOH, what I did was standard ANSI C, and
should always work.

Hmm... I just thought of something:  I didn't check to make sure that
arguments enclosed in single or double quotes are handled correctly by
the redir code.  It might be worthwhile to check this out, although it
probably also applies to spawn*() as well as system().

-- 
---------------------------------------------------------------------
| John M. Aldrich, aka Fighteer I      |   mailto:fighteer AT cs DOT com   |
| God's final message to His Creation: | http://www.cs.com/fighteer |
| "We apologize for the inconvenience."| <<< This tagline under >>> |
|                      - Douglas Adams | <<<    construction    >>> |
---------------------------------------------------------------------