Message-ID: <328E6843.246A@cs.com>
Date: Sat, 16 Nov 1996 17:20:03 -0800
From: "John M. Aldrich" <fighteer AT cs DOT com>
Reply-To: fighteer AT cs DOT com
Organization: Three pounds of chaos and a pinch of salt
MIME-Version: 1.0
To: Morten Welinder <welinder AT rentec DOT com>
CC: djgpp-workers AT delorie DOT com
Subject: Re: djverify and cpu detection
References: <9611162029 DOT AA18342 AT robbie DOT rentec DOT com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Morten Welinder wrote:
> 
> 1. The asm ("...") code in diagnose.c fails to specify that
>    ebx/ecx/edx get destroyed.  Bad code may be generated.
> 
> 2. Why does it .byte and .long so often?  (And what are all
>    those '\r's doing _after_ the '\n's?)
> 
> 3. The method used -- as used everywhere else in djgpp --
>    may have a problem: it is said that an interrupt (the
>    event, not the handler) will clear the AC flag.
> 
>    If this is true then we will occasionally detect 486s
>    and up as 386s.
> 
>    So someone with a PC should run the cpu detection code
>    10^8 times and see if it is reliable.  Don't forget to
>    run it in real mode as well as v86 mode.  If it turns
>    out we do have a problem we can think of a solution then.

The code was given to me by Mark Habersack, and I just pasted it in
verbatim.  But that is one of the major reasons I want people to test it
on as many platforms as possible.  :)

As for the \n\r, I guess Mark's been thinking DOS-ish too much.  If you
could make the changes you think are appropriate and mail me the new
code, I'd be very grateful.

Thanks!

-- 
John M. Aldrich, aka Fighteer I <fighteer AT cs DOT com>

-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GCS d- s+:- a-->? c++>$ U@>++$ p>+ L>++ E>+ W++ N++ o+ K? w(---) O-
M-- V? PS+ PE Y+ PGP- t+(-) 5- X- R+ tv+() b+++ DI++ D++ G e(*)>++++
h!() !r !y+()
------END GEEK CODE BLOCK------