Date: Tue, 7 May 1996 09:54:35 +0200 (IST)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
To: Douglas Rupp <drupp AT cs DOT washington DOT edu>
Cc: drupp AT cs DOT washington DOT edu, djgpp-workers AT delorie DOT com
Subject: Re: Patch bug
In-Reply-To: <199605070233.TAA11024@june.cs.washington.edu>
Message-Id: <Pine.SUN.3.91.960507094730.15501H@is>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII


On Mon, 6 May 1996, Douglas Rupp wrote:

> > can extra CR characters mess it up?  Are you sure you use the latest
> > version of `patch'?  A bug in `fseek' and `ftell' in the initial release
> > of v2.0 made `patch' buggy; please get the latest version of pat21b.zip,
> > dated 22-Feb-96 or later and try it. 
> 
> I build patch from pat21s.zip and it messed up.

No, I meant the binary pat21b.zip from that date.  If you build it
yourself, make sure your libc.a is dated 22-Feb-96.  I'm quite sure the
problems you see are related to that bug. 

> patch <gcc-272.dif is exactly how I invoke my modifed patch (w/ _fmode=binary)
> and it works fine.  The sources and patch are both Unix style.

I probably miss something because I cannot understand how this can work,
unless you have buggy `ftell' (it indeed worked only with files open in
binary mode).  Did you test it with DOS-style text files?  Did it work? 
(I'm afraid it won't because `patch' explicitly tests for `\n'
characters.) Can you please post an example of a source and a patch file
that don't work with the original `patch'?