X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp AT delorie DOT com
X-Recipient: dj AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
	mime-version; bh=8u31GF90pw5A8T58xtc8Y6HzDab67d4eld84e0ETYJk=; b=bgkcc5TY51gA
	pkTFaJ8oeFfLNVVI1HQSc3vVngLgJRuE/DaVFC0871Ts/sqcmb9CL/hWVLbtDgJ8PwNep6Y0jH4e8
	974rXY5hQxwlYHuLevpHMJTklEx9PWkeo6DcdszQt6Bx5ZIsp8XFyvt+QsI7lv1nW3ioZCbBVQTTz
	6vZyHOel3B91TDjS/X06CNmnDOYip7FX99UljDdP7uaJQ7rPGtzcjQxsjNheIdBeCU73DrGGTDky2
	DM3pUnk843NqKi4ig24lvQqMRf4Pe7j6cdJ/IK7Hi74oRohkhca2dqgID8xCAK8X55mdyNZv05+Va
	x0RhwP1sw17TRkwi3MOehA==;
Date: Sat, 13 Apr 2024 10:12:25 +0300
Message-Id: <86ttk5rb1i.fsf@gnu.org>
From: "Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
To: Pali <pali AT pali DOT im>
Cc: cwsdpmi AT earthlink DOT net, dj AT delorie DOT com, sezeroz AT gmail DOT com,
        djgpp AT delorie DOT com
In-Reply-To: <20240413003717.7nfr3h5pakhviqdd@pali> (message from Pali on Sat,
	13 Apr 2024 02:37:17 +0200)
Subject: Re: Error handling of ECX in __dpmi_set_page_attributes()
References: <20240320231522 DOT fowijjlk2h6ilw6x AT pali>
 <86o7b82gnq DOT fsf AT gnu DOT org>
 <20240321175845 DOT shig623b45gtlfm5 AT pali>
 <20240404184844 DOT manihh7yyr7ed7hv AT pali>
 <86h6g6so3r DOT fsf AT gnu DOT org> <20240413003717 DOT 7nfr3h5pakhviqdd AT pali>
Reply-To: djgpp AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Sat, 13 Apr 2024 02:37:17 +0200
> From: Pali <pali AT pali DOT im>
> Cc: cwsdpmi AT earthlink DOT net, dj AT delorie DOT com, sezeroz AT gmail DOT com,
> 	djgpp AT delorie DOT com
> 
> On Friday 12 April 2024 16:32:40 Eli Zaretskii wrote:
> > > Date: Thu, 4 Apr 2024 20:48:44 +0200
> > > From: Pali <pali AT pali DOT im>
> > > Cc: Charles Sandmann <cwsdpmi AT earthlink DOT net>, dj AT delorie DOT com,
> > > 	sezeroz AT gmail DOT com, djgpp AT delorie DOT com
> > > 
> > > On Thursday 21 March 2024 09:22:17 Eli Zaretskii wrote:
> > > > Should we at least check in the
> > > > function's code that the value in ECX is non-negative and smaller than
> > > > the value of ECX set by the caller?
> > > 
> > > That is a good idea. Here is an alternative change which does this check:
> > 
> > Thanks, installed.
> 
> I would propose to extend documentation for DPMI 0507h function to
> include information about modifying the size member.
> 
> --- src/libc/dpmi/api/d0507.txh
> +++ src/libc/dpmi/api/d0507.txh
> @@ -27,2 +27,10 @@ attribute word.
>  
> +On error this function changes @code{@var{info}->size} to the number
> +of modified pages as reported by DPMI function AX = 0x0507.  If DPMI
> +function reports that all input pages were modified or even more
> +number of pages than the input number of pages were modified then it
> +is treated as invalid value reported by DPMI function and so this
> +functions changes @code{@var{info}->size} to 0 as probably no page
> +was modified.
> +
>  The DJGPP startup code calls this function to uncommit the so-called

Thanks, installed (with some punctuation and wording changes).