X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=to:subject:message-id:date:from:references:in-reply-to:mime-version
         :from:to:cc:subject:date:message-id:reply-to;
        bh=TX5IzycpiMPxh++69g2bJTKR2Gxjy4Ez3UNZUk+MBFc=;
        b=UZMiIaOLewpOCZHm3XHDBNYIVrjrIi3vQq7lS0ClW/BfcNp8bOJUf1APwCBcZLcRRY
         ZKwHaosiOKshTzmLo3OlUAh2VZZ03xmMOmKBGx5LmkWKNXTrhATEisgwcTqnxx3+3cpR
         n6IbTMy6zcZCb8dzWWSkg0rdeyP7NJjS5m4PK7ZZjOGsHN+mGm7PWzkSAxjC1qCnABDb
         sKqUUkq4Vf08W8dS0ZBgXfRWUS9lNN5cfw7BPuZRvMALj6fBV0JIS4sW8q3tQGN+7IsW
         92ftDjbnkLBVTliFTTpHcBsfNx+EY3RTmvFFVeOGPMFpYKnuaalbz/Xi19zLeM+mrQ1x
         O3eQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=to:subject:message-id:date:from:references:in-reply-to:mime-version
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=TX5IzycpiMPxh++69g2bJTKR2Gxjy4Ez3UNZUk+MBFc=;
        b=mzcPtpa9Z9y2iqXUgQ6eCqkMsDTfT/DqpbOT3DeZd2XhEHU+i44+Uy5hWgOQy3SmfP
         yWIA7Mb6q6yMtvBGdOGRdmQKoLguj9x7LE+xBBbaEr5bPXjsy1CYKc3zgoJK6PmxsyRZ
         Ox1U9NZUGAxnHJCkMY0lQ1NZCxZ+IzkX/OMVgfu57hiPfYBpzMmJV2nUNbxgVnkFu3HW
         IDxclVmMhvgP6e3NdICWraIYVdowjwXO7eN5wwTQ6NmuEwKVNEbdlGev/G1/pU/Bzl3A
         xQCgSso9BJsh7bA/bQIXGIVVeZ0kkUQFocuwTa7RsQQh1T4k6xbh2NYvc4eZqhjhgSf6
         kVEA==
X-Gm-Message-State: AO0yUKV8AZnLn1nbH115TVY/x50d9DM+I5lp7JPmEV0kWOsIxEv1ewut
	T4/sAOApFDxyB9ZmHWjYNctgHuuT3sBmafy7scvr8m6n
X-Google-Smtp-Source: AK7set84qN/n2whLKtVOGon/o1SWEk+sLL9wPVfnOTSXxM6yMeqsoFX/KPeheOoWHF0tM/eqMensoY7wRn+8NBTcFYo=
X-Received: by 2002:adf:e3d0:0:b0:2bf:ed03:3969 with SMTP id
 k16-20020adfe3d0000000b002bfed033969mr196438wrm.95.1675187732310; Tue, 31 Jan
 2023 09:55:32 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAA2C=vCMFJmBv6P_dAiDCRzCCn=gNZpjdPcfWH=e3QtR6NTi+w@mail.gmail.com>
References: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ AT mail DOT gmail DOT com>
 <835ycn529o DOT fsf AT gnu DOT org> <CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA AT mail DOT gmail DOT com>
 <CAA2C=vD8V=rpNwvuC+1Mj6GjNjyfByWVND8eiuOkF6R7ECYVvQ AT mail DOT gmail DOT com> <CAA2C=vCMFJmBv6P_dAiDCRzCCn=gNZpjdPcfWH=e3QtR6NTi+w AT mail DOT gmail DOT com>
From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
Date: Tue, 31 Jan 2023 20:55:31 +0300
Message-ID: <CAA2C=vAQKDYihM7EeYDKSsq0wSqds69xd47oWG=H=SGrKBGTsg@mail.gmail.com>
Subject: Re: [PATCH] dxe3gen: add support for using an exports file.
To: djgpp AT delorie DOT com
Content-Type: text/plain; charset="UTF-8"
Reply-To: djgpp AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> If you guys don't catch any gotchas, I plan to apply this 3r version to
> cvs.

Question:  Should I actually make any missing exports an error ?
Patch inlined below.

diff -up djgpp/src/dxe/dxe3gen.c~ djgpp/src/dxe/dxe3gen.c
--- djgpp/src/dxe/dxe3gen.c~
+++ djgpp/src/dxe/dxe3gen.c
@@ -1317,12 +1317,14 @@ static int write_dxe(FILE *inf, FILE *ou
   }
   DEBUG_PRINT_SYMBOL_TABLE_EPILOG();

-  if (opt.verbose && opt.num_names && opt.num_names != dh.n_exp_syms)
+  if (opt.num_names && opt.num_names != dh.n_exp_syms)
   {
+    errcount = opt.num_names - dh.n_exp_syms;
+    fprintf(stderr, "Error: %d symbols to be exported are
missing:\n", errcount);
     for (j = 0; j < opt.num_names; j++)
     {
       if (opt.export_names[j])
-        printf("missing export: `%s'\n", opt.export_names[j]);
+        fprintf(stderr, "missing export: `%s'\n", opt.export_names[j]);
     }
   }