X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f X-Recipient: djgpp AT delorie DOT com X-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HyKAc0uCsY9piC7reQb7z3jai5dFsb958JJ0/rOjFcs=; b=iVNL6csIA2BV Xsd1d+cJu+NLNi70dDgiQl/rAeTDEY20IB/2GevdUiTcYEg0Xntf7lj8DRbliQbnH2MKDYzY214xo fBn5EP2MPheQhrXLngPgrJyskdWseIk9LTou6aDqxXaU+nR56N1/xvcuBNmxk6biaWoTPfOXLi2kK XkJssMKhRKcTAPGxn2Ldz0lt5inJKofSDxogp6VWEZDZ9OzvmJJ3ekoIEDI23MoWVPBlseomvBV7J cNsrU5SY8b5PcF+a4x89Mynt/j6jXy8EvSh/se3QNOlEBNDTsgtZPXG2sS6x389chAxHI8LThcnWP CJ95sYzBw1BlAQPLrx3XxQ==; Date: Sun, 29 Jan 2023 09:54:03 +0200 Message-Id: <834js993ok.fsf@gnu.org> From: "Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]" To: djgpp AT delorie DOT com In-Reply-To: (djgpp AT delorie DOT com) Subject: Re: [PATCH v3] dxe3gen: invoke ld/as via gcc References: <83sfft981m DOT fsf AT gnu DOT org> Reply-To: djgpp AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: djgpp AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk > Date: Sun, 29 Jan 2023 08:15:17 +0100 > From: "J.W. Jagersma (jwjagersma AT gmail DOT com) [via djgpp AT delorie DOT com]" > > On 2023-01-29 07:19, Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com] wrote: > >> Date: Sat, 28 Jan 2023 23:09:30 +0100 > >> From: "J.W. Jagersma (jwjagersma AT gmail DOT com) [via djgpp AT delorie DOT com]" > >> > >> Posting this in a new thread since the other became way too long. > >> > >> This applies to current cvs, and should address all raised concerns. I > >> additionally noticed and fixed a small inconsistency in the -h text, as > >> linker options are now wrapped via -Wl. > > > > Thanks. I have only one question: > > > >> + new_argv[0] = dxe_cc; > >> + new_argv[1] = "-nostdlib"; > >> + new_argv[2] = "-Wl,-X,-S,-r"; > >> + new_argv[3] = "-o"; > >> + new_argv[4] = TEMP_O_FILE; > >> + new_argv[5] = "-T"; > >> + new_argv[6] = dxe_sc; > > > > Why do we need -nostdlib? It wasn't used before, AFAICT. > > This prevents gcc from implicitly linking in any libraries (libc, libgcc and > crt0.o), as it wants to do by default. It wasn't there before, since it's a > gcc-specific option. Sorry, I missed the fact that your original patch also had this option.