X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
	mime-version; bh=mA7t7ylbU2JEO5Ord9GF6LWFFeBdGF41NoTGTksf6YA=; b=SxLy5PR4l2Rt
	0POWvo5QA0yw0RpShnmEU3uZQ7B1yJRX+6140jdfmcWI4kveZzOaHjcP4XJPpKgkby2vkesOICHWz
	4OKPCfvRsyh8g08ef1nl6ovtnnI7DRS2AeGn5NwkNvp8p/E6nDid4c9H9NtLpzwHXwQX8//2wvv4m
	wRxMh5OPtri0stSbG/kKIAcsT9jCtZP1/lS/oS6NH7NuWFE6eHkkrM7PmeB4GYuQPwMU8gThGoLuf
	Hw666+GIK1yCqLXhHcm33yGQ+0Mwd81knHXUDkmOvwDrcMhXtFgjIlP6IF5hQicw8iYPCr4b3cvQp
	4h1G+HKNZcmURTzKaxHMYQ==;
Date: Sat, 28 Jan 2023 10:54:35 +0200
Message-Id: <835ycravjo.fsf@gnu.org>
From: "Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
To: djgpp AT delorie DOT com
In-Reply-To:
	<CAA2C=vByQZVnfkF_0UX+4p+rcm8uTehwSnM9hSHW-m=Dc4HBtw AT mail DOT gmail DOT com>
	(djgpp AT delorie DOT com)
Subject: Re: DXE3 with std::vector
References: <edefcfee-d1ce-415a-8d1d-525a660fb0d5n AT googlegroups DOT com>
 <CAA2C=vCduRPA7Ky-kDqs=QtO-qi=DQczM6FMHhB+=Ltof54P=Q AT mail DOT gmail DOT com>
 <c934abb6-c11e-0087-cd32-365d25d3f154 AT gmail DOT com> <CAA2C=vCHMXDD8iewRStieHyTcgjGF3=d29LmMT53vrzGYe+zMQ AT mail DOT gmail DOT com>
 <CACuL_+CZm++qhEr7PedDmQaTxjZu9d-rVSw1bgPeist7XZ+dpQ AT mail DOT gmail DOT com>
 <CAA2C=vDPwv5G9DeFKyKFqt39cDDmO4LmDtbtMyoMdRR2xeEkow AT mail DOT gmail DOT com>
 <3b8f674c-bca3-c679-952e-f8ba5af196e7 AT gmail DOT com> <CAA2C=vBptnTAy2TA-pj5JCbAUJMiXkAAoP_xYFZZJ99iB7v9mQ AT mail DOT gmail DOT com>
 <500850be-fd64-3f82-a1e1-929903084e9b AT gmail DOT com> <CAA2C=vA0zXX3Sb49WBzU5g1-8dmO5G5wrb3uT+tLRq2LB0wu5Q AT mail DOT gmail DOT com>
 <3d9271ae-266d-ee7b-853b-984857ced1c8 AT gmail DOT com> <CAA2C=vD6sZpTicPh0xuJ16r76qBZ5BZro6x=9+=Z+P-0f_eRSA AT mail DOT gmail DOT com>
 <f04cd9db-fe76-219c-bacb-47711df559e2 AT gmail DOT com> <CAA2C=vCv_bpM+iinTcreMJD_gv34Rna3jLspiLFfESFuNxOtoA AT mail DOT gmail DOT com>
 <af7fa08a-b074-0a4c-5e2f-99299940e3cc AT gmail DOT com> <CAA2C=vB22rof4HPV_dVPy4tVmsmeDMy4G4r2Vx-_YLwOW6C9ug AT mail DOT gmail DOT com>
 <bbdf1853-5454-93b2-fcf9-2306c6949c86 AT gmail DOT com> <CAA2C=vBDi8gwhVVacnhnP+eufCkMNK4DancpOjnD7ScOWCEF6g AT mail DOT gmail DOT com>
 <83sffvbux1 DOT fsf AT gnu DOT org> <CAA2C=vAuq+O2gRRM--E0YAPy6D1pLgcP2r0-4+sCLis=kwGYzA AT mail DOT gmail DOT com>
 <83mt63azwi DOT fsf AT gnu DOT org> <CAA2C=vByQZVnfkF_0UX+4p+rcm8uTehwSnM9hSHW-m=Dc4HBtw AT mail DOT gmail DOT com>
Reply-To: djgpp AT delorie DOT com

> From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
> Date: Sat, 28 Jan 2023 10:55:47 +0300
> 
> >>>  makefile.dxe uses "?=", which AFAICT we never used in the DJGPP
> >>>  build tree
> >>
> >> I can revert that part: Tell me?
> >
> > If it is not necessary, I think reverting it would be best.
> 
> Sure, I can do that.

Thanks.

> >>>  the code will no longer heed DXE_LD_LIBRARY_PATH and DJDIR
> >>
> >> I documented that in the applied patch:
> >>
> >> https://www.delorie.com/bin/cvsweb.cgi/djgpp/src/docs/kb/wc206.txi
> >> https://www.delorie.com/bin/cvsweb.cgi/djgpp/src/docs/kb/wc206.txi.diff?r1=1.15&r2=1.16
> >
> > Instead of documenting, could we keep the previous behavior?
> [...]
> >> One can simply use -L/some/path -lfoo (verified that it works)
> >
> > OK, but can we actually still honor those variables in the new code,
> > so that if someone does use them, they could still use their scripts
> > and build procedures?
> [...]
> > I don't know.  DJGPP is a very old project, and it is sometimes used
> > in strange and tricky configurations for perhaps unorthodox purposes.
> > By removing these variables we could inadvertently break someone's
> > project in some rare cases.  Why do that if we could instead keep the
> > old behavior intact?
> 
> You mean, even if it won't be used, compute the libdir from either
> DXE_LD_LIBRARY_PATH or DJDIR and add it as -L ?

AFAIK, DJDIR is always set in DJGPP.  The original code used
DXE_LD_LIBRARY_PATH if it was defined, else fell back to DJDIR.  I
think either keeping that, or maybe adding one more fallback, for when
neither DXE_LD_LIBRARY_PATH nor DJDIR is define, would be a
backward-compatible change.

> > I don't know.  DJGPP is a very old project, and it is sometimes used
> > in strange and tricky configurations for perhaps unorthodox purposes.
> 
> With those in mind, what do you think about compatibility with old
> gcc versions? I found that at least gcc-2.95 doesn't work after this
> patch possibly because it doesn't handle -T dxe.ld on the command
> line.

I thought you said that if actually invoked from the shell prompt, it
did handle "-T dxe.ld"?

If that is not true, can we use -Xlinker or -Wl instead, so as to
communicate this option directly to the linker?