X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f X-Recipient: djgpp AT delorie DOT com X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=eOXtDmJNHut725MTN30q/KbUDz1Wpz/jvlQlLXVjr1c=; b=UM4Kof7c6bbzW2y5O+j2d57f/048Flp+cK/DBCtJwD/oCNa9jVIHqQNn2iVOWqCtVi fTFWdjTsvT3vN16RBzckD88vYocir9TTqt/f1mMvrcZR340NF7V3/R0i1gH3H8irIaUA LRICBRqiyEPsMfe6uxKth8ugzrrRzAVxnvQzlp3OyQ1ClU0EhKPbPWb7qHI1ThZc7Ga5 ybfr69YcV8ZmI8h1P5noZ1RtzHX/9oSK2luHNOvOlhAi6tzSuE7qSzkHtLaBtF4VBC3B XSNdBCJbD6tOkpViQUzrl3bdjcZ8VsKvNUmiP+JeU5zk0KxorfoYv3Zxfatxnf+c/2fa lh5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eOXtDmJNHut725MTN30q/KbUDz1Wpz/jvlQlLXVjr1c=; b=Kua0apJRORWKw8tphXJxdfKbgh1IJZjprwb6Pe7WaCthUETYRutjPNh+mXDDYieNDu uipMUaf4ImDsHfDwDMjLZnriDOxJG0z1LX4etqlt7fvBpZUpdUdVvDdGSmpE1vCGABc8 eFesXTYQCgQAeiqm+JtwvspT5DSs1iEYzBCBRiRIEknPpL73Z5wLxWJqgBDHeHihkmc/ yiBUvekfCfUgLnXEDGl9n8KEKnHybzxFtP1Gka+bHfZ9Vb06wxCI6TDiiDtc2vewgRu9 VDwBcKYAFbQC2T+3AwMv3FVIvKR1dx59H36H9Sr8UXdvaOPDjexRcL62hask6nhqNdmw Wrrg== X-Gm-Message-State: AFqh2kppyVqqyx8DYI/4P/LBr9VTR8ZnnCswX7Krs7OmPCiQR1thtyS7 iw/Yu+iQ38qsawi2pJOrf+r9gOn7a02rjq/eZ4RvouiT X-Google-Smtp-Source: AMrXdXtgy62JsH08SI0e/iN6BI4TW4kOxHSoebboDt/S5CHRf5O6VnBGKg0rkSIu7na+QfgijmxhGwJ5oChE8Akmpcc= X-Received: by 2002:a5d:6b01:0:b0:2bc:7d91:f00 with SMTP id v1-20020a5d6b01000000b002bc7d910f00mr973418wrw.68.1674852371082; Fri, 27 Jan 2023 12:46:11 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <83sffvbux1.fsf@gnu.org> References: <3b8f674c-bca3-c679-952e-f8ba5af196e7 AT gmail DOT com> <500850be-fd64-3f82-a1e1-929903084e9b AT gmail DOT com> <3d9271ae-266d-ee7b-853b-984857ced1c8 AT gmail DOT com> <83sffvbux1 DOT fsf AT gnu DOT org> From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]" Date: Fri, 27 Jan 2023 23:46:10 +0300 Message-ID: Subject: Re: DXE3 with std::vector To: djgpp AT delorie DOT com Content-Type: text/plain; charset="UTF-8" Reply-To: djgpp AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: djgpp AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk >> DJ, Eli: I'd like to apply this patch. Any objections? > > I won't fight its inclusion, but I wonder whether all of the aspects > of this patch have been considered. I'm worried by the changes in > behavior this patch brings. At least the following stand out: > > the code will no longer heed DXE_LD_LIBRARY_PATH and DJDIR I documented that in the applied patch: https://www.delorie.com/bin/cvsweb.cgi/djgpp/src/docs/kb/wc206.txi https://www.delorie.com/bin/cvsweb.cgi/djgpp/src/docs/kb/wc206.txi.diff?r1=1.15&r2=1.16 > makefile.dxe uses "?=", which AFAICT we never used in the DJGPP > build tree I can revert that part: Tell me? > What if someone wants to use those > environment variables to tweak the build of a DXE? One can simply use -L/some/path -lfoo (verified that it works) > Also, this comment no longer describes what the code does, after the > change: > >> /* Allright, now run the assembler on the resulting file */ >> - sprintf(cmdbuf, "%s -o %s %s", dxe_as, TEMP_O_FILE, TEMP_S_FILE); >> + sprintf(cmdbuf, "%s -c -o %s %s", dxe_cc, TEMP_O_FILE, TEMP_S_FILE); > Change to something like this?? /* Allright, now build resulting file */ > If you aren't going to wait for me to answer your questions, why ask > me? I got one response, thought it was enough. Sorry -- will wait all next time.