X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=to:subject:message-id:date:from:references:in-reply-to:mime-version
         :from:to:cc;
        bh=UAQTrkW/3uONz2wCYGrpKTFqhE3g4SrhQiMseyXM78U=;
        b=dsHNBz0hO+cJjmJczZx2EeDRdV5ADNdZv/FsyROvGaLrZ0novGj5SMvzpRwiWvNZas
         81TmUhPDEhsWxOaSHddLFaVeccPQKQkNTHMj0FdLfxnA116lV4vuhfpZC86cMXoEBqtm
         FcLs8JkGI24N/z9jfW8emkZbhtTpOVGJhSyjbz4eqqmqsZATx+I+aZzCy8VFJaJ4hRJo
         t8xcITxQCcRn6DetmOzbZ3G8n5voZnVex7IuRuFmlh/2+Xnxzp8YTcdCKjW/h0BfLi12
         8YJTGlF6DnhHc7RplqtzpKAPLg24qP2nfnST1EYV8DdKEMRW3tPKSQAH/HU2fjv9iQ1R
         EfbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=to:subject:message-id:date:from:references:in-reply-to:mime-version
         :x-gm-message-state:from:to:cc;
        bh=UAQTrkW/3uONz2wCYGrpKTFqhE3g4SrhQiMseyXM78U=;
        b=l8rzNt4eZYhQ/AqPyNXhbklyT0EbdT7pdqitG5RlHijg2hY93fcwKom3oeIkkFoy7W
         IH/dmJvN7w2Yeb7RLzRQRPwjMKX9FpvQcgLXzT07zGHIDxVp67NlptYQHUndS3A3b4h9
         aoUQPft52d2zf47783HUDRQKBLeCciOT2KJ8bC4qqP8mK5SiE7Wks3KJ1LsftJd0CkaI
         jjdVNJSEeJ14X5ie5CUclgbHmfQSFofQQflzm0Gx/eb+TBi6oNckdwFhS90z2aOuni/D
         CZxfcd0CYXk4LLjMupUKV49CrsQszkjBN5we+Atm4aVsgTzDECF2QXho0QSZOkbyyj1P
         n/jQ==
X-Gm-Message-State: ACgBeo3xUQ9M/Xl7B6LRTFmgIU+7pmG2feHZ4K6CcdKO+d4yLrDnOLrI
	Yt/1Is9ZqTdv7gspdIjWaT5yzkcDVfHh5e9NWurkr+QRjSM=
X-Google-Smtp-Source: AA6agR7RgYm0WBPGaGPkK7TlJXaVV/DO2Gw5/QwMYFyzQA2SHZ1voWE78tSH2sF89yWh18Ixobv+Nt3y5Gz+y6OLzsI=
X-Received: by 2002:a7b:cc18:0:b0:3a3:64c3:71fc with SMTP id
 f24-20020a7bcc18000000b003a364c371fcmr13653593wmh.185.1659845662808; Sat, 06
 Aug 2022 21:14:22 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <83b98192-9ce6-495d-8eaf-9c4e6906cb5dn@googlegroups.com>
References: <3c11b033 DOT 75 DOT 182562fe32f DOT Coremail DOT lostxwind AT 163 DOT com>
 <414f3e66 DOT a1 DOT 182565154ec DOT Coremail DOT lostxwind AT 163 DOT com> <CAA2C=vCKayVtwbC7xaPtcfZ2a6PDPLAa8K2diCRN52=yi9R_Og AT mail DOT gmail DOT com>
 <83b98192-9ce6-495d-8eaf-9c4e6906cb5dn AT googlegroups DOT com>
From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
Date: Sun, 7 Aug 2022 07:14:22 +0300
Message-ID: <CAA2C=vBOy1Yj26JqRHMNjHqv9DE19wuTDZOA0Rq7s0B1xeoq0w@mail.gmail.com>
Subject: Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI
 register and doesn't save it
To: djgpp AT delorie DOT com
Content-Type: text/plain; charset="UTF-8"
Reply-To: djgpp AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On 8/6/22, Stefan Ring (stefanrin AT gmail DOT com) [via djgpp AT delorie DOT com]
<djgpp AT delorie DOT com> wrote:
>> src\libc\dpmi\api\d0306.S, line 2-line 4.
>>
>> code before fix:
>> #define USE_EBX
>> #define USE_EDI
>> #include "dpmidefs.h"
>>
>> possible fix:
>> #define USE_EBX
>> #define USE_EDI
>> #define USE_ESI
>> #include "dpmidefs.h"
>
> Yes, looks very reasonable, given that the DPMI call explicitly changes
> (e)si.

OK then, is the following patch OK to apply?

___dpmi_get_raw_mode_switch_addr: push/pop esi.

Reference issue:
https://www.delorie.com/djgpp/mail-archives/browse.cgi?p=djgpp/2022/08/02/03:07:56

Index: src/libc/dpmi/api/d0306.S
===================================================================
RCS file: /cvs/djgpp/djgpp/src/libc/dpmi/api/d0306.S,v
retrieving revision 1.1
diff -u -p -r1.1 d0306.S
--- src/libc/dpmi/api/d0306.S	12 Mar 1995 04:52:56 -0000	1.1
+++ src/libc/dpmi/api/d0306.S	7 Aug 2022 04:08:36 -0000
@@ -1,6 +1,7 @@
 /* Copyright (C) 1995 DJ Delorie, see COPYING.DJ for details */
 #define USE_EBX
 #define USE_EDI
+#define USE_ESI
 #include "dpmidefs.h"

 	.text