X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp AT delorie DOT com
Date: Thu, 10 Dec 2020 20:25:47 +0200
Message-Id: <831rfx4ixg.fsf@gnu.org>
From: "Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
To: djgpp AT delorie DOT com
In-Reply-To:
	<CAA2C=vDL+YWHssNteT71jUNxYAJkxwiNXrKp1O618tY6bHHcxg AT mail DOT gmail DOT com>
	(djgpp AT delorie DOT com)
Subject: Re: Difficulties compiling libc from repository using gcc 10.N.0
References: <5FD1FEA1 DOT 7010304 AT gmx DOT de> <8816d501-9f33-4d68-4235-1935a83580f6 AT gmail DOT com>
 <CAA2C=vACivjbYiU7yVpyFdzKjjKB10E1tvqShLPQ6i31cuKrDA AT mail DOT gmail DOT com> <111383e4-b3db-f346-b71c-749dee17dc9e AT gmail DOT com> <CAA2C=vDL+YWHssNteT71jUNxYAJkxwiNXrKp1O618tY6bHHcxg AT mail DOT gmail DOT com>
Reply-To: djgpp AT delorie DOT com

> From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
> Date: Thu, 10 Dec 2020 20:44:01 +0300
> 
> --- src/debug/fsdb/makefile	27 Sep 1998 17:04:26 -0000	1.3
> +++ src/debug/fsdb/makefile	10 Dec 2020 17:39:43 -0000
> @@ -12,6 +12,9 @@ EOBJS += unassmbl.o
>  
>  include $(TOP)/../makefile.inc
>  
> +#see screen.h as to why this is needed
> +CFLAGS += -fcommon
> +

This part looks OK.

> --- src/libc/ansi/stdlib/exit.c	2 May 2015 07:32:10 -0000	1.9
> +++ src/libc/ansi/stdlib/exit.c	10 Dec 2020 17:39:43 -0000
> @@ -15,7 +15,7 @@
>  
>  struct __atexit *__atexit_ptr = 0;
>  
> -void (*__stdio_cleanup_hook)(void);
> +extern void (*__stdio_cleanup_hook)(void); /* stdio/stdiohk.c */

This part I don't understand: are you saying that it is no longer the
default that a function not explicitly declared 'static' has the
external linkage?  Why do we need an explicit 'extern' qualifier?

Thanks.