X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f X-Recipient: djgpp AT delorie DOT com X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Date: Fri, 28 Apr 2017 22:30:08 +0300 Message-Id: <83d1bwmitb.fsf@gnu.org> From: "Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com> To: djgpp AT delorie DOT com In-reply-to: <CAA2C=vC3EtQJmndPY7NRN_cSnDLbNpJPPM2FV6H4E9DcLoWgTg AT mail DOT gmail DOT com> (djgpp AT delorie DOT com) Subject: Re: dxe3gen does not handle relocs > 65535 References: <CAA2C=vC8s9Kg9LhewQmUMtiJNm+f=Gu5b-m_QXgiTgNufQQpfQ AT mail DOT gmail DOT com> <CAA2C=vBNvQsBU+2_0JhJQqJr41pV=VWTUxgyS29VjUK6zL3paA AT mail DOT gmail DOT com> <CAA2C=vDKwsv7i5jNOGEpOEdokwsWbP3MV_eHU_M6s79cn=NkZg AT mail DOT gmail DOT com> <CAA2C=vC3EtQJmndPY7NRN_cSnDLbNpJPPM2FV6H4E9DcLoWgTg AT mail DOT gmail DOT com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e Reply-To: djgpp AT delorie DOT com > From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com> > Date: Fri, 28 Apr 2017 22:20:39 +0300 > > Here is a somewhat cleaned-up patch with a changelog entry: Thanks. Some minor comments: > + if (opt.verbose) > + printf("%s: real nrelocs: %lu\n", progname, (unsigned long)real_nrelocs); is this printf really necessary? > + } else { > + real_nrelocs = dh.nrelocs; > + } Please use the style adopted in the rest of the source, with regards to braces. > Should apply to CVS? If no one speaks up in a couple of days, please do.