X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f X-Recipient: djgpp AT delorie DOT com X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Date: Sat, 14 Jan 2017 14:16:47 +0200 Message-Id: <83bmv9bzv4.fsf@gnu.org> From: "Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]" To: djgpp-workers AT delorie DOT com CC: djgpp AT delorie DOT com In-reply-to: (djgpp-workers AT delorie DOT com) Subject: Re: memory.h References: <83h951c41o DOT fsf AT gnu DOT org> <83d1fpc24q DOT fsf AT gnu DOT org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e Reply-To: djgpp AT delorie DOT com > From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp-workers AT delorie DOT com]" > Date: Sat, 14 Jan 2017 15:11:03 +0300 > Cc: djgpp AT delorie DOT com > > > What problems does including stdlib.h cause? > > Problems are not from including stdlib.h but from not including string.h > E.g. cpu.c from flac library includes memory.h possibly to get the proto > for memset(). Their decision might be debatable, but that's what they do > and it works everywhere except for djgpp, for which I suggested a patch > http://lists.xiph.org/pipermail/flac-dev/2017-January/006109.html > > > Would it be okay to > > simply add string.h, without removing stdlib.h? That way, we don't > > create possible backward incompatibilities that could break existing > > programs. > > > > That's good with me. Should I push it to cvs? Yes, please. Thanks.