X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f X-Recipient: djgpp AT delorie DOT com Message-ID: <575DCBFA.3070008@gmx.de> Date: Sun, 12 Jun 2016 22:54:18 +0200 From: "Juan Manuel Guerrero (juan DOT guerrero AT gmx DOT de) [via djgpp AT delorie DOT com]" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.13) Gecko/20101206 SUSE/3.1.7 Thunderbird/3.1.7 MIME-Version: 1.0 To: djgpp AT delorie DOT com CC: bug-make AT gnu DOT org Subject: Re: Some DJGPP specific fixes for Make 4.2.1 and later. References: <575D996C DOT 1000507 AT gmx DOT de> <83y46afhaj DOT fsf AT gnu DOT org> In-Reply-To: <83y46afhaj.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:TF/28Mn1e9YLvNhXEs2i0Cjb80s6aQ+aNy3bdo+bi0rNux/fA9m JrXUSaDMnbe1/Wo4DYobsUggRbUdd1iBR+YGm3NrpWBTfWL8hnHESDjDFA8OB/EFct6bMfj lD4XOGOnJEwmR18zaoeDxX8wpU3ly7sLPK3uLiljj3gdrLETtyBk1GnIzJDPBiNOLmO6eZM GptFKMZiC7I16SzaV0Hvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:qXHz1l3TRM8=:o+sHcgCWr3kd7k3xy4iGYt 9Z86DnYL0HPyN3axguQffAru9PW4u2qnBUZNKJsCyY3ws4AImyO0iZXVW4t4BLde4Cow6gLZF FAAJjPqNj5cyOzZtZJCS4ux8fiOJzAcTtYKX/Vb6aZVbU6VBdV43knzHfdhnAybEo7on4Vr6b lZHay4zhjpM7w9LloO/3CqxICywBBttdvBH4SL6jLNlZngfdf9MzGB5wUMa/DGH6BM2tLpJ2H hQTgGKcDm6oy8rVOoJnYGi+uXVnKdndIHz9PHGhsp5gSNISIB6l6LnMv+p83gIDPMmbjpYzDd 8icYHX1FWcMSKWS71OTD7pdpmnxdXhzbplgo7nKiNGtfiRTrMEcj5MfYt2RwdYtHcMR6x+ZAS pHeUw55zSxBvDvipD9gjj3x7oFEfxLIs4i8LbbSiEoevloFTm4vgeFmKi6/4BfkX3+5DrGMfm PYy0PXPe9cvTn9/QIQf8cP0zg6/ya2lYhCTMOn4oC2WRiCOIKjMWLeKpSrSZFsef273OOWeMq yCeWYgmpNhIbv/hO2u9B1uVbz5YI0Bku9YFURC0BqedqdfkevYdzoMrtuLui/hetkT5TXnGrG e/RZ3ns2Yw/M/+2xeG9E3HvUuodTiPCpOJhH/T/rGeWj27Sb40P4XenwedbAoMNWzmCgzKi50 7QQpj0eH1FzEivzKRJrt8wA4IJ2pbBPqrZrijQMIctwZipeAjvPWMWuCHxurkXgiDvDbkqkCx oJLu6flkpozoMuBp25jT6YeFOg7hwoTNMgqKBueUwhHVS4HGvHlOngEn638XdENbbc5YVCafy 7K9aFus Reply-To: djgpp AT delorie DOT com Am 12.06.2016 19:28, schrieb Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]: >> Date: Sun, 12 Jun 2016 19:18:36 +0200 >> From: "Juan Manuel Guerrero (juan DOT guerrero AT gmx DOT de) [via djgpp AT delorie DOT com]" >> >> - For systems like MSDOS, WINDOWS32 and other ones, the function get_bad_stdin >> is defined as a no-op macro in os.h but at the same time exists an >> implementation of the function in posixos.c. This implementation >> is always compiled no matter if __MSDOS__ and/or MAKE_JOBSERVER is >> defined or not in posixos.c. To avoid this contradiction, I have put >> the get_bad_stdin definition inside the same #ifdef than the ones used >> in os.h. Please inspect the patch. This approach is only a suggestion; >> may be there is a different way to solve this issue. > > posixos.c is not supposed to be compiled on MSDOS (or any other > non-Posix system). Why is it being compiled in the DJGPP build? > > The other changes look fine to me, thanks. Did not know this. Because I never know how well maintained are the DJGPP specific files like Makefile.DOS, etc I prefer to configure it by running the configure script. But this had produced a Makefile that had posixos added to the list of object files thus making the build fail. But if that file is supposed not to used at all with non-Posix systems, please ignore the proposed changes concerning posixos.c. That is ok with me. Regards, Juan M. Guerrero