X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp AT delorie DOT com
Date: Wed, 13 May 2015 22:17:54 +0300
From: "Eli Zaretskii (eliz AT gnu DOT org)" <djgpp AT delorie DOT com>
Subject: Re: bad pragma in dir.h? (and our structrure packing)
In-reply-to: <CAA2C=vB-YiGkyx5dJpa=hcBh0O4_NiEKh2tKm5OHyNX3vW7HsQ@mail.gmail.com>
X-012-Sender: halo1 AT inter DOT net DOT il
To: djgpp AT delorie DOT com
Message-id: <83a8x8jnh9.fsf@gnu.org>
References: <CAA2C=vCgLHdH3BJxastGzUsJzhiRddytiYwB1MP_aaiiVpC4nA AT mail DOT gmail DOT com> <83k2wcjt8e DOT fsf AT gnu DOT org> <CAA2C=vB-YiGkyx5dJpa=hcBh0O4_NiEKh2tKm5OHyNX3vW7HsQ AT mail DOT gmail DOT com>
Reply-To: djgpp AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Wed, 13 May 2015 21:55:53 +0300
> From: "Ozkan Sezer (sezeroz AT gmail DOT com)" <djgpp AT delorie DOT com>
> 
> On 5/13/15, Eli Zaretskii (eliz AT gnu DOT org) <djgpp AT delorie DOT com> wrote:
> >> Date: Wed, 13 May 2015 18:29:39 +0300
> >> From: "Ozkan Sezer (sezeroz AT gmail DOT com)" <djgpp AT delorie DOT com>
> >>
> >> In dir.h, structs ffblk and ffblklfn are surrounded by #pragma pack(1)
> >> and #pragma pack(4), obviously with purpose of having those two structs
> >> at byte packing.  But the restoration of the original packing by that
> >> #pragma pack(4) seems wrong: do we not need a #pragma pack() in there,
> >> or am I missing something?
> >
> > Wasn't that already fixed in the past?
> 
> Well, obviously not. that pragma pack(4) is there in the cvs
> 
> >  I have vague recollections of
> > having discussed that long ago, o maybe look in the archives (of this
> > list or or djgpp-workers).

I knew that it rang a bell.  See this discussion:

  http://www.delorie.com/djgpp/mail-archives/browse.cgi?p=djgpp-workers/2004/05/01/13:56:35

I guess it never got acted upon.  My solution for the problem it
caused in Emacs was to add

  #pragma pack(0)

right after inclusion of dir.h; you can still find that in src/msdos.c
in Emacs sources.