Message-Id: <m0zDrfo-000S4wC@inti.gov.ar>
Comments: Authenticated sender is <salvador AT natacha DOT inti DOT gov DOT ar>
From: "Salvador Eduardo Tropea (SET)" <salvador AT inti DOT gov DOT ar>
Organization: INTI
To: "Andris Pavenis" <pavenis AT lanet DOT lv>, Robert Hoehne <robert DOT hoehne AT gmx DOT net>,
        djgpp AT delorie DOT com
Date: Tue, 1 Sep 1998 11:46:40 +0000
MIME-Version: 1.0
Content-type: text/plain; charset=ISO-8859-1
Subject: Re: Little bug in RHIDE
In-reply-to: <199809011326.PAA53504@ieva06.lanet.lv>
References: <35EBC669 DOT 609C5AF3 AT messa DOT ge>
Content-Transfer-Encoding: 8bit
Precedence: bulk

"Andris Pavenis" <pavenis AT lanet DOT lv> wrote:
> 
> > Hello everybody,
> > I think I found a little bug in RHIDE. Because Robert Höhne (the author)
> > wishes that bug reports are reported on this list first, here it is:
> > File->Open / F3 opens the 'Open a file' window. The bug shows itself
> > (under Windows 95 and 98) when I try to select a file in that window
> > which name is larger than 127 (yep, I found that by pure chance :)
> > characters. When I try to do that, RHIDE immediately exits without any
> > message.
> > 127 characters is the boundary. It doesn't matter if the filename ends
> > with '.c' or not. It also doesn't matter if the filename contains
> > several periods, one period or none at all.
> > I have reinstalled RHIDE in a directory of it's own (just extracted the
> > official rhide14b.zip) and I still got this behaviour. Ofcourse, there
> > is no problem when I use the -n option.
> > 
> 
> It is real bug in RHIDE (both 1.4 and 1.4.5, I tested only latest)
> 
> The problem is that TFileInfoPane::draw () in such situation writes 
> to TDrawBuffer more data than allowed width (currenty 132 for 
> DJGPP version and 1024 for Linux one: see 
> tvision/include/tvconfig.h for definition of maxViewWidth)
> 
> I see 2 possible solutions:
>    - enlarge maxViewWidth in tvconfig.h (as I understand Win95     
>      does not allow filenames larger than 260 bytes however I 
>       haven't tested that)
>    - check for data size to be written into TDrawBuffer

I think the best is a check in the TFileInfoPane::draw. Enlarging the 
maxViewWidth is a very bad idea because it makes *all* the buffers greater 
and I don't see any good reason for it. The 132 is just because that's the 
maximun number of columns supported, perhaps it should be moved to 160 
because SVGAText can setup such a mode, but not more.
I must evaluate the TDrawBuffer alternative with more detail.
Thanks Andris.
BTW, yesterday I was testing RHIDE 1.4.5.1 compiled here and I was able to 
debug the editor without problems. I used gdb 4.16: What did you used? Your 
patches changes the makefiles to search for 4.17, are you really using it? I 
changed it back to 4.16. 
I want to fix other common problems in RHIDE and release it.

Greetings, SET


------------------------------------ 0 --------------------------------
Visit my home page: http://set-soft.home.ml.org/
or
http://www.geocities.com/SiliconValley/Vista/6552/
Salvador Eduardo Tropea (SET). (Electronics Engineer)
Alternative e-mail: set-soft AT usa DOT net set AT computer DOT org
ICQ: 2951574
Address: Curapaligue 2124, Caseros, 3 de Febrero
Buenos Aires, (1678), ARGENTINA
TE: +(541) 759 0013