Mailing-List: contact cygwin-developers-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT cygwin DOT com Delivered-To: mailing list cygwin-developers AT cygwin DOT com Subject: Re: pthreads patches From: Robert Collins To: Thomas Pfaff Cc: cygwin-developers AT cygwin DOT com In-Reply-To: References: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-/tXlTTYiRhKEMI//smOL" Organization: Message-Id: <1042148095.13639.529.camel@lifelesslap> Mime-Version: 1.0 Date: 10 Jan 2003 08:34:55 +1100 --=-/tXlTTYiRhKEMI//smOL Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2003-01-10 at 08:24, Thomas Pfaff wrote: > I have applied my outstandig patches for pthreads. These are > pthread_cond_init, pthread_mutex, a patch regarding cancellation and a > modified version of my pthread types patch (Rob has announced a different > patch some time ago but never applied it. If he will finish it he might > revert my patch) plus new mutex tests to the testsuite. >=20 > The pthread mutex patch will change the mutex default type from recursive > to errorchecking (all unix systems that i know are either errorchecking o= r > fast (deadlocking) by default). > Any objections ? None here. My approach for pthreads patchs is that any that has a test case to check the behaviour it's modifying is ok to go in after a once-over eyeball by me - I've had that on all your work to date, and I'm glad to see the code finally in cygwin. Any patches that don't have corresponding tests will need much closer inspection. Cheers, Rob --=20 GPG key available at: . --=-/tXlTTYiRhKEMI//smOL Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQA+Her/I5+kQ8LJcoIRAq+jAJ9HtMuPe6uak0+xaWcXc/k2Ac1uRQCgvgYK 70j2HD5nl6xfzIicVKme23k= =smSc -----END PGP SIGNATURE----- --=-/tXlTTYiRhKEMI//smOL--