Mailing-List: contact cygwin-developers-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT cygwin DOT com Delivered-To: mailing list cygwin-developers AT cygwin DOT com Date: Wed, 22 May 2002 13:39:09 +0200 From: Corinna Vinschen To: cygwin-developers AT cygwin DOT com Subject: Re: Should sys/types.h include sys/sysmacros.h? Message-ID: <20020522133909.E10218@cygbert.vinschen.de> Reply-To: cygwin-developers AT cygwin DOT com Mail-Followup-To: cygwin-developers AT cygwin DOT com References: <20020501180344 DOT GI3160 AT tishler DOT net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.22.1i On Tue, May 21, 2002 at 04:46:40PM -0400, Gerald S. Williams wrote: > Jason Tishler wrote: > > Actually, I just determined that sys/types.h includes cygwin/types.h. > > So, should I include sys/sysmacros.h in cygwin/types.h instead? > > But cygwin/types.h includes sys/sysmacros.h already. I think > the problem is that sys/types.h isn't always including > cygwin/types.h. A closer look reveals that it doesn't do this > if _POSIX_THREADS is defined. > > I don't know why it would only include cygwin/types.h if > _POSIX_THREADS isn't defined--perhaps that should be changed? I've checked in two patches which should solve that problem. newlib/libc/include/sys/types.h includes now always if __CYGWIN__ is defined and cygwin/types.h defines the pthread stuff now only if _POSIX_THREADS is defined. So sys/sysmacros.h is now included (more or less) unconditionally and especially the uid16/32_t etc. types are defined, too. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer mailto:cygwin AT cygwin DOT com Red Hat, Inc.