Mailing-List: contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT cygwin DOT com>
List-Help: <mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT cygwin DOT com
Delivered-To: mailing list cygwin-developers AT cygwin DOT com
Date: Mon, 3 Dec 2001 23:38:52 +0100
From: Corinna Vinschen <vinschen AT redhat DOT com>
To: Earnie Boyd <earnie_boyd AT yahoo DOT com>
Cc: cygdev <cygwin-developers AT cygwin DOT com>
Subject: Re: src/winsup/w32api ChangeLog include/commdlg.h  ...
Message-ID: <20011203233852.C10634@cygbert.vinschen.de>
Reply-To: cygdev <cygwin-developers AT cygwin DOT com>
Mail-Followup-To: Earnie Boyd <earnie_boyd AT yahoo DOT com>,
	cygdev <cygwin-developers AT cygwin DOT com>
References: <20011203195935 DOT 7122 DOT qmail AT sources DOT redhat DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20011203195935.7122.qmail@sources.redhat.com>; from earnie@cygwin.com on Mon, Dec 03, 2001 at 07:59:35PM -0000

On Mon, Dec 03, 2001 at 07:59:35PM -0000, earnie AT cygwin DOT com wrote:
> CVSROOT:	/cvs/src
> Module name:	src
> Changes by:	earnie AT sources DOT redhat DOT com	2001-12-03 11:59:35
> 
> Modified files:
> 	winsup/w32api  : ChangeLog 
> 	winsup/w32api/include: commdlg.h ipexport.h iphlpapi.h iptypes.h 
> 	                       rpcdcep.h rpcproxy.h winbase.h windef.h 
> 	                       windows.h winnt.h winsock.h winsock2.h 
> 	                       winuser.h 
> 	winsup/w32api/lib: advapi32.def dinput.c iphlpapi.def kernel32.c 
> 	                   scrnsave.c test.c user32.def 
> Added files:
> 	winsup/w32api/include: accctrl.h aclapi.h 
> 
> Log message:
> 	2001-12-03  Earnie Boyd  <earnie AT users DOT sf DOT net>
> [...]
> 	2001-11-23  Danny Smith  <dannysmith AT users DOT sourceforge DOT net>
> 	
> 	* include/winbase.h (OSVERSIONINFO[AW],VER_PLATFORM_WIN32s,
> 	VER_PLATFORM_WIN32_WINDOWS,VER_PLATFORM_WIN32_NT): Move from
> 	here ...
> 	* include/winnt.h: ... to here.
> 	* include/winbase.h (VerifyVersionInfo[AW]): Add declaration.
> 	* include/winnt.h (OSVERSIONINFOEX[AW]): Add structure definitions
> 	and typedefs.
> 	(VER_NT_WORKSTATION,VER_NT_DOMAIN_CONTROLLER,VER_NT_SERVER):
> 	Add defines.

What's that?  This change breaks the change from

> 	2001-11-12  Corinna Vinschen  <corinna AT vinschen DOT de>
> 	
> 	* include/winbase.h (OSVERSIONINFOEX): Add definition.
> 	* include/winnt.h: Add VER_NT_* and VER_SUITE_* defines.

Now we have three VER_NT_* defines which each is defined twice in
winnt.h and OSVERSIONINFO[AW] and OSVERSIONINFOEX[AW] are also
defined twice, in winbase.h and in winnt.h.

This breaks building setup and cygwin.

Could you please care for that, Earnie?  Otherwise I'll patch that
tomorrow according to MSDN.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.