Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Date: Fri, 7 Sep 2001 13:19:21 +0200
From: Corinna Vinschen <vinschen AT redhat DOT com>
To: cygwin-developers AT cygwin DOT com
Subject: Re: Figured out how to reproduce vfork/rsync bug! (proposed fix)
Message-ID: <20010907131921.C17245@cygbert.vinschen.de>
Reply-To: cygdev <cygwin-developers AT cygwin DOT com>
Mail-Followup-To: cygwin-developers AT cygwin DOT com
References: <20010906142836 DOT 7323 DOT qmail AT lizard DOT curl DOT com> <20010906164756 DOT 19885 DOT qmail AT lizard DOT curl DOT com> <20010906203947 DOT Q537 AT cygbert DOT vinschen DOT de> <20010906184747 DOT 20476 DOT qmail AT lizard DOT curl DOT com> <20010906185326 DOT 20521 DOT qmail AT lizard DOT curl DOT com> <20010906161343 DOT A4873 AT redhat DOT com> <20010906210458 DOT A8242 AT redhat DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010906210458.A8242@redhat.com>; from cgf@redhat.com on Thu, Sep 06, 2001 at 09:04:58PM -0400

On Thu, Sep 06, 2001 at 09:04:58PM -0400, Christopher Faylor wrote:
> On Thu, Sep 06, 2001 at 04:13:43PM -0400, Christopher Faylor wrote:
> >On Thu, Sep 06, 2001 at 02:53:26PM -0400, Jonathan Kamens wrote:
> >>I think I'll try the patch that cgf just sent out and see if it makes
> >>this problem go away.
> >>
> >>It will be very amusing if we discover that the bug I'm encountering
> >>is the same as Egor's.
> >
> >Try this.
> 
> I think this is the actual fix.  I noticed this about four hours ago but
> concluded that there just HAD to be something wrong with the cygheap
> stuff since that is what I had previously been working on.
> 
> I believe that cygheap was not the problem in this case.  What is actually
> happening is that the it is assumed prot_info_ptr is a zero filled array --
> that is not the case when you set that long environment variable.  The
> environment variable space was freed and then reused by the cmalloc
> in fhandler_socket::fhandler_socket.  So, when you look at the buffer
> it actually contains the contents of the environment variable.  That is
> acceptable behavior for cmalloc, of course but it looks like the
> subsequent code in fhandler_socket.cc needs assumes that this buffer
> is zeroed.
> 
> Anyway, I checked in the fix below.  It seems to resolve the problems.
> On further investigation, my previous fix was bogus.  It just resulted
> in never freeing space for the cygwin environment, which is incorrect.
> 
> Jonathan, Corinna, could you try the CVS version of cygwin and see
> if it fixes the problem?

It seems to fix it.  I'm mildly surprised, though.  prot_info_ptr is
used twice, first in `fixup_before_fork_exec' where it's getting
it's content and then in `fixup_after_fork' where it's content is
used to create the new socket handle.

If it's actually _used_ before being _set_ that would mean,
`fixup_after_fork' has been called w/o calling `fixup_before_fork_exec'
first.  But that would be simply wrong.

So the only other explanation would be that `WSADuplicateSocketA'
needs a zero filled buffer on input?!?

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.