Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT sources DOT redhat DOT com Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com Date: Fri, 29 Jun 2001 23:15:41 -0400 From: Christopher Faylor To: cygwin-developers AT cygwin DOT com, cygwin-patches AT cygwin DOT com Subject: Re: hierarchy in setup (category stuff) Message-ID: <20010629231541.A12500@redhat.com> Reply-To: cygwin-patches AT cygwin DOT com Mail-Followup-To: cygwin-developers AT cygwin DOT com, cygwin-patches AT cygwin DOT com References: <20010629172912 DOT A8991 AT redhat DOT com> <032001c100fe$d62310c0$806410ac AT local> <20010629205735 DOT K9607 AT redhat DOT com> <034701c10106$34f6b6e0$806410ac AT local> <036501c10108$b55383c0$806410ac AT local> <20010629221309 DOT A11334 AT redhat DOT com> <038301c1010a$bab7e840$806410ac AT local> <039201c1010b$856f0c80$806410ac AT local> <20010629223227 DOT C11334 AT redhat DOT com> <03cb01c1010e$6d809dc0$806410ac AT local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.11i In-Reply-To: <03cb01c1010e$6d809dc0$806410ac@local>; from robert.collins@itdomain.com.au on Sat, Jun 30, 2001 at 12:43:20PM +1000 On Sat, Jun 30, 2001 at 12:43:20PM +1000, Robert Collins wrote: >I think this gets them all. I thought I'd not trashed Michael's whate space >changes - although where code moved between functions, they would have been >lost regardless. > >I'm happy if rolling back is easier for you, but I suspect that its the same >effort either way. This wasn't all of them either. Some of my changes affected your new code so there was some hand-applying necessary. I have checked in something that seems to work. I'm still not completely satisfied with the Skip/Keep stuff, though. Your code was assuming that you could just set Skip and that was ok but my changes made Skip an invalid state if the package was installed. So, "Keep" is appropriate in those cases. I think that I got that working again but I don't like the way that I did it. I think I have to sleep on this. cgf