Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Date: Mon, 11 Jun 2001 17:52:59 +0400
From: egor duda <deo AT logos-m DOT ru>
X-Mailer: The Bat! (v1.53 RC/4)
Reply-To: egor duda <cygwin-developers AT cygwin DOT com>
Organization: deo
X-Priority: 3 (Normal)
Message-ID: <164196998989.20010611175259@logos-m.ru>
To: Christopher Faylor <cygwin-developers AT cygwin DOT com>
Subject: Re: Recent changes to path_conv::check -- ouch
In-Reply-To: <20010610235131.A10749@redhat.com>
References: <20010610201750 DOT A8503 AT redhat DOT com> <20010610235131 DOT A10749 AT redhat DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi!

Monday, 11 June, 2001 Christopher Faylor cgf AT redhat DOT com wrote:

CF> [following up on myself]
CF> Kazuhiro's patch has forced me to look into this function a little
CF> more.  It looks like we're just calling rootdir repeatedly rather than
CF> invoking the OS.  I guess that is ok.  I'd rather not have even that
CF> perfomance penalty but I don't know if it can be avoided.

yes, i was trying to make update_fs_info() as fast as possible in most
cases. if all symlinks in path stay on the same drive/share, OS is
called only once. As for GetCurrentDirectory(), i wasn't sure if
mount-converted path always has rootdir component present. if we can
guarantee that, GetCurrentDirectory() can be eliminated.

repeated calls to rootdir() is, most of time, just strchr()+strcmp(),
and as i've removed appropriate calls from path_conv::check() i don't
think we'll have any performance hit at all, or it'd be negligible
compared to calls to GetFileAttribute().

Egor.            mailto:deo AT logos-m DOT ru ICQ 5165414 FidoNet 2:5020/496.19