Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT sources DOT redhat DOT com Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com Date: Tue, 20 Feb 2001 11:07:13 -0500 From: Christopher Faylor To: cygwin-developers AT cygwin DOT com Subject: Re: fhandler_console Message-ID: <20010220110713.C29217@redhat.com> Reply-To: cygwin-developers AT cygwin DOT com Mail-Followup-To: cygwin-developers AT cygwin DOT com References: <16286062992 DOT 20010216183758 AT logos-m DOT ru> <20010219214951 DOT A23483 AT redhat DOT com> <7888578378 DOT 20010220130012 AT logos-m DOT ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.11i In-Reply-To: <7888578378.20010220130012@logos-m.ru>; from deo@logos-m.ru on Tue, Feb 20, 2001 at 01:00:12PM +0300 On Tue, Feb 20, 2001 at 01:00:12PM +0300, Egor Duda wrote: >Hi! > >i've looked a bit deeper into fhandler_console code, and think it >needs more fixing. for example, this command: > >echo -e -n "\033[?" && echo -e "1000h" > >won't enable mouse events reporting ("saw_question_mark" should be >persistent across write calls) and several other issues. so i think >several variables which are related to console "state" should be made >members of class fhandler_console. I agree. I was just noticing the static variables yesterday. >the only thing i want to get advice on -- is fhandler_console::dup >ever called? i've never seen so. if i miss something and it is >called, then all such "persistent state" information should be >stored not in fhandler_console itself, but in separate structure >referenced from fhandler_console and common for all fhandler_console >instances. > >Chris, can you tell if your cygheap code eliminates the need for >fhandler_console::dup? No, fhandler_console::dup isn't really related to cygheap. It is just a method that is called automatically from dup(). cgf