Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT sources DOT redhat DOT com Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com Date: Tue, 20 Feb 2001 13:00:12 +0300 From: Egor Duda X-Mailer: The Bat! (v1.45) Personal Reply-To: Egor Duda Organization: DEO X-Priority: 3 (Normal) Message-ID: <7888578378.20010220130012@logos-m.ru> To: cygwin-developers AT cygwin DOT com Subject: fhandler_console In-reply-To: <20010219214951.A23483@redhat.com> References: <16286062992 DOT 20010216183758 AT logos-m DOT ru> <20010219214951 DOT A23483 AT redhat DOT com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi! i've looked a bit deeper into fhandler_console code, and think it needs more fixing. for example, this command: echo -e -n "\033[?" && echo -e "1000h" won't enable mouse events reporting ("saw_question_mark" should be persistent across write calls) and several other issues. so i think several variables which are related to console "state" should be made members of class fhandler_console. the only thing i want to get advice on -- is fhandler_console::dup ever called? i've never seen so. if i miss something and it is called, then all such "persistent state" information should be stored not in fhandler_console itself, but in separate structure referenced from fhandler_console and common for all fhandler_console instances. Chris, can you tell if your cygheap code eliminates the need for fhandler_console::dup? Egor. mailto:deo AT logos-m DOT ru ICQ 5165414 FidoNet 2:5020/496.19