Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Date: Thu, 15 Feb 2001 00:17:51 +0300
From: Egor Duda <deo AT logos-m DOT ru>
X-Mailer: The Bat! (v1.45) Personal
Reply-To: Egor Duda <cygwin-developers AT cygwin DOT com>
Organization: DEO
X-Priority: 3 (Normal)
Message-ID: <1872134499.20010215001751@logos-m.ru>
To: Christopher Faylor <cygwin-developers AT cygwin DOT com>
CC: lhall AT rfk DOT com
Subject: Re: unknown commands in \033[xx;yy;zzm aren't ignored
In-reply-To: <20010214160951.A18991@redhat.com>
References: <2943025 DOT 20010214235759 AT logos-m DOT ru>
 <20010214160951 DOT A18991 AT redhat DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi!

Thursday, 15 February, 2001 Christopher Faylor cgf AT redhat DOT com wrote:

>>however. the reason is this fragment
>>
>>    default:
>>      fg = default_color & (FOREGROUND_BLUE | FOREGROUND_GREEN |
>>                            FOREGROUND_RED);
>>      bg = default_color & (BACKGROUND_BLUE | BACKGROUND_GREEN |
>>                            BACKGROUND_RED | BACKGROUND_INTENSITY);
>>      bold = default_color & FOREGROUND_INTENSITY;
>>      break;
>>
>>in fhandler_console::char_command. shouldn't this code be eliminated?

CF> Are you saying that the 666 is causing incorrect behavior?

yes.  when  we  scan  \033[1;666m  command,  we  first  set  fg and bg
variables   to  correct  "bold"  values, an then we see 666 and quoted
code reset fg and bg to the fixed values based on default_color.

CF>  If  so,  I  think   I  agree.   Why  should cygwin be setting any
CF> defaults at all if it doesn't understand the numeric code?

i'll submit a patch.

Egor.            mailto:deo AT logos-m DOT ru ICQ 5165414 FidoNet 2:5020/496.19