Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT sourceware DOT cygnus DOT com Delivered-To: mailing list cygwin-developers AT sourceware DOT cygnus DOT com From: Chris Faylor Date: Thu, 13 Apr 2000 11:49:10 -0400 To: cygwin-developers AT sourceware DOT cygnus DOT com Subject: Re: More setup changes Message-ID: <20000413114909.C12180@cygnus.com> Reply-To: cygwin-developers AT sourceware DOT cygnus DOT com Mail-Followup-To: cgf AT cygnus DOT com, cygwin-developers AT sourceware DOT cygnus DOT com References: <20000413012229 DOT A11346 AT cygnus DOT com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.1.8i In-Reply-To: ; from mdejong@cygnus.com on Thu, Apr 13, 2000 at 07:23:48AM -0700 On Thu, Apr 13, 2000 at 07:23:48AM -0700, Mo DeJong wrote: >On Thu, 13 Apr 2000, Chris Faylor wrote: >A directory like usr/bin/ in the tar file was >getting converted to C:\Cygwin\usr\bin, so >setup.c thought it is was a file not a directory. >When setup.c goes to write out the command to >delete a file or directory, it checks to see >if the name ends with a \ char. > >I do not know if this ever worked, but it is >broken now so I whipped up a patch for the >problem. This patch will append a \ char on >the end of a filename that setup.c is processing. Thank you for the patch, but I don't see how it is correct to always add a slash on the end of every file that is reported by tar. In most cases these are files that are being extracted. >This also changes the directory where the uninstaller will cd to >internally and turns the install.bat file into a windows style name so >it can be deleted. I don't understand what you mean. What's a "windows style name"? >This patch also adds /usr/local/bin to the default PATH set in >cygwin.bat. Users that install programs with autoconf will be >installing into /usr/local by default so it should be on the PATH. >Oh yeah, this patch also fixes a little compiler warning >(the void ** bit). That's not a fix, is it? It's a workaround. The correct fix is probably to correct a prototype somewhere. cgf