Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT sourceware DOT cygnus DOT com Delivered-To: mailing list cygwin-developers AT sourceware DOT cygnus DOT com Date: Fri, 25 Feb 2000 12:19:39 -0500 From: "'Chris Faylor'" To: "Fifer, Eric" Cc: "'cygwin-developers AT sourceware DOT cygnus DOT com'" Subject: Re: some bug fixes Message-ID: <20000225121939.B31566@cygnus.com> Reply-To: cygwin-developers AT sourceware DOT cygnus DOT com References: <779F20BCCE5AD31186A50008C75D99791716E5 AT SILLDN_MAIL1> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.1.4i In-Reply-To: <779F20BCCE5AD31186A50008C75D99791716E5@SILLDN_MAIL1>; from EFifer@sanwaint.com on Fri, Feb 25, 2000 at 05:13:16PM -0000 On Fri, Feb 25, 2000 at 05:13:16PM -0000, Fifer, Eric wrote: > >>I don't understand your select patch, so I'm not going to check it in. > >I was just porting some code that happened to do a select >to check exceptions on stdout. In this case peek_pipe was >failing with an error, but the error was really due to PeekNamedPipe >being used with the write end of a pipe. So, it was failing with >ACCESS_DENIED because GENERIC_READ was not one of the create options >on the handle. Anyway, I just added a check to see if peek_pipe >was looking at the write end of a pipe. I tried to check the >device against FH_PIPEW, but unfortunately it is only set to >the more generic FH_PIPE (not FH_PIPER, or FH_PIPEW). That is fixable. But, unless I'm missing something, you still are not specifically checking only for exceptions as the ChangeLog indicated. cgf