Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Unsubscribe: <mailto:cygwin-developers-unsubscribe-archive-cygwin-developers=delorie DOT com AT sourceware DOT cygnus DOT com>
List-Subscribe: <mailto:cygwin-developers-subscribe AT sourceware DOT cygnus DOT com>
List-Archive: <http://sourceware.cygnus.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sourceware DOT cygnus DOT com>
List-Help: <mailto:cygwin-developers-help AT sourceware DOT cygnus DOT com>,
	<http://sourceware.cygnus.com/ml/#faqs>
Sender: cygwin-developers-owner AT sourceware DOT cygnus DOT com
Delivered-To: mailing list cygwin-developers AT sourceware DOT cygnus DOT com
Date: Fri, 3 Sep 1999 18:30:17 -0400
From: Chris Faylor <cgf AT cygnus DOT com>
To: Corinna Vinschen <corinna AT vinschen DOT de>
Cc: cygdev <cygwin-developers AT sourceware DOT cygnus DOT com>,
        Vincent_Virgilio AT nmss DOT com
Subject: Re: raw device patch
Message-ID: <19990903183017.A2600@cygnus.com>
Mail-Followup-To: Corinna Vinschen <corinna AT vinschen DOT de>,
	cygdev <cygwin-developers AT sourceware DOT cygnus DOT com>,
	Vincent_Virgilio AT nmss DOT com
References: <37CFF473 DOT ADBFFA13 AT vinschen DOT de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.95.6i
In-Reply-To: <37CFF473.ADBFFA13@vinschen.de>; from Corinna Vinschen on Fri, Sep 03, 1999 at 06:16:51PM +0200

I've applied this patch, or at least it's in my local repository.
As soon as our CVS server comes back up, I'll check it in.

*** Note to anybody else who has submitted a patch recently --
*** We haven't been *** ignoring you.  DJ and I are very busy
*** right now, so if a patch *** requires any inspection it's
*** been put off for a while until we have time.

cgf

On Fri, Sep 03, 1999 at 06:16:51PM +0200, Corinna Vinschen wrote:
>
>Hi Chris, hi all!
>
>I have patched fhandler_raw.cc and fhandler_tape.cc because the
>S_ISCHR flag wasn't set correctly. This has produced the cpio
>problem that was reported in the cygwin mailing list by 
>Vincent Virgilio <Vincent_Virgilio AT nmss DOT com>
>
>Regards,
>Corinna
>
>
>ChangeLog:
>==========
>
>Fri Sep 3 18:15:00 1999  Corinna Vinschen  <corinna AT vinschen DOT de>
>
>	* fhandler_raw.cc (fhandler_dev_raw::fstat): Added S_ISCHR
>	to mode bits.
>	* fhandler_tape.cc (fhandler_dev_tape::fstat): Erased setting
>	of S_ISCHR because it's set in fhandler_dev_raw::fstat now.
>Index: fhandler_raw.cc
>===================================================================
>RCS file: /src/cvsroot/winsup-990818/fhandler_raw.cc,v
>retrieving revision 1.1.1.1
>diff -u -p -r1.1.1.1 fhandler_raw.cc
>--- fhandler_raw.cc	1999/08/19 19:42:55	1.1.1.1
>+++ fhandler_raw.cc	1999/09/03 15:56:19
>@@ -128,9 +128,10 @@ fhandler_dev_raw::fstat (struct stat *bu
>     }
> 
>   memset (buf, 0, sizeof *buf);
>-  buf->st_mode = S_IRUSR | S_IWUSR |
>-    S_IRGRP | S_IWGRP |
>-    S_IROTH | S_IWOTH;
>+  buf->st_mode = S_IFCHR |
>+                 S_IRUSR | S_IWUSR |
>+                 S_IRGRP | S_IWGRP |
>+                 S_IROTH | S_IWOTH;
>   buf->st_nlink = 1;
>   buf->st_blksize = devbuf ? devbufsiz : 1;
>   buf->st_dev = buf->st_rdev = get_device () << 8 | (unit & 0xff);
>Index: fhandler_tape.cc
>===================================================================
>RCS file: /src/cvsroot/winsup-990818/fhandler_tape.cc,v
>retrieving revision 1.1.1.1
>diff -u -p -r1.1.1.1 fhandler_tape.cc
>--- fhandler_tape.cc	1999/08/19 19:42:55	1.1.1.1
>+++ fhandler_tape.cc	1999/09/03 15:56:27
>@@ -158,8 +158,6 @@ fhandler_dev_tape::fstat (struct stat *b
>     {
>       struct mtget get;
> 
>-      buf->st_mode |= S_IFCHR;
>-
>       if (! ioctl (MTIOCGET, &get))
> 	{
> 	  buf->st_blocks = get.mt_capacity / buf->st_blksize;
>
>


-- 
cgf AT cygnus DOT com
http://www.cygnus.com/