From: khan AT xraylith DOT wisc DOT edu (Mumit Khan)
Subject: Re: DLL init patch for loading cygwin DLL from MSVC app
28 Oct 1998 18:44:29 -0800
Message-ID: <Pine.SUN.3.93.981028200824.29430C-100000.cygnus.cygwin32.developers@modi.xraylith.wisc.edu>
References: <19981028175646 DOT 28408 AT cygnus DOT com>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
To: Geoffrey Noer <noer AT cygnus DOT com>
Cc: cygwin32-developers AT cygnus DOT com, cgf AT cygnus DOT com

On Wed, 28 Oct 1998, Geoffrey Noer wrote:

> 
> Scanning it quickly, it looks pretty good to me, but I want to take a
> much closer look.  In terms of including anything more in b20, it's
> getting awfully late but this particular patch does look safe in that
> the downside is small since the new code only gets invoked in a
> situation which never should occur for Cygwin apps using a Cygwin DLL.
> So I will try to include it in B20 unless problems with it are brought
> to my attention soon.

Actually, cgf just pointed that there's too much copying of code,
and I'm trying out a 3-line patch right now. I'll resubmit when I've
rebuilt and tested it.

Something like the following:
  
  int
  dll_dllcrt0 (HMODULE h, per_process *p)
  {
    if (user_data == NULL)
      dll_crt0 (p);
    return _the.recordDll (h, p);
  }

which, if it works (I was getting segfaults, but I had other changes
that I've backed out since which could've been causing this), should
be completely safe.

> Finally, I did get your assignment via fax.  I'm assuming you've
> already sent off the actual signed hard copy?

It's on its way.

Regards,
Mumit