From: corinna DOT vinschen AT cityweb DOT de (Corinna Vinschen)
Subject: Re: Changes to winsup-980812
20 Aug 1998 03:35:20 -0700
Message-ID: <35DBF475.403FBF5D.cygnus.cygwin32.developers@cityweb.de>
References: <35D7692D DOT 55D70D8 AT cityweb DOT de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: Christopher Faylor <cgf AT cygnus DOT com>
Cc: cygwin32-developers AT cygnus DOT com

Christopher Faylor wrote:

> These look like some interesting fixes.
>
> Would you be willing to sign a release form so that we can look
> into incorporating them into the product?
>
> Instructions for the steps you need to take to get your changes into
> cygwin32 are located at:
>
> http://www.cygnus.com/misc/gnu-win32/contrib.html
>

....

> --
> cgf AT cygnus DOT com             "Everything has a boolean value, if you stand
> http://www.cygnus.com/      far enough away from it."  -- Galena Alyson Canada

Dear Christopher,

I have agreed the assignment form and it's on the road.
I'm really sorry, but the file 'fhandler_tape.cc' had an error
which is corrected by the patch at the end of the mail.

By the way:
IMHO, the implementation of the function 'gethostname()' is
worse than nothing, because the name, returned by
'GetComputerName()' may not be the same name as
returned by the wsock-function 'gethostname()'.
I have patched it at home, but I havn't sent the patch,
because I haven't realized the 'deep sense' of the
official version (W95?). Sergey Okhapkin has written to me
'TCP/IP may be not installed'.
Does anybody need 'gethostname()' if he/she doesn't have
installed TCP/IP????

Greetings
Corinna

Now the patch:
--------- snip ----------
*** fhandler_tape.cc.orig       Sun Aug 16 11:47:47 1998
--- fhandler_tape.cc    Thu Aug 20 00:31:56 1998
*************** fhandler_dev_tape::raw_write(const void
*** 254,261 ****
          return -1;
          }
        tapedev |= TD_WRITTEN;
!         if ((tapebufend += written2) == tapebufsiz)
          tapebufend = 0;
        }
      }
    } else if (len > 0) {
--- 254,265 ----
          return -1;
          }
        tapedev |= TD_WRITTEN;
!         if (written2 == tapebufsiz)
          tapebufend = 0;
+       else {
+         memmove(tapebuf, tapebuf + written2, tapebufsiz - written2);
+         tapebufend = tapebufsiz - written2;
+       }
        }
      }
    } else if (len > 0) {