Mailing-List: contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT cygwin DOT com>
List-Help: <mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT cygwin DOT com
Delivered-To: mailing list cygwin-developers AT cygwin DOT com
Subject: Re: [PATCH] change to thread.cc -- need feedback
From: Robert Collins <rbcollins AT cygwin DOT com>
To: cygwin-developers AT cygwin DOT com
In-Reply-To: <20020930151227.GA10898@redhat.com>
References: <20020930151227 DOT GA10898 AT redhat DOT com>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature";
	boundary="=-6nqZQt1s18mjBAo6h45m"
Date: 01 Oct 2002 06:45:11 +1000
Message-Id: <1033418715.11273.206.camel@lifelesswks>
Mime-Version: 1.0


--=-6nqZQt1s18mjBAo6h45m
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 2002-10-01 at 01:12, Christopher Faylor wrote:
> I've changed the static declarations in thread.cc to use
> NO_COPY and things seem to be working better in my build.

Ah yes, good thing.=20
=20
> In doing this, I noticed that a CreateEvent and a CreateMutex were using
> a default argument 1 (security attributes).
>=20
> I changed these to an explicit "no inherit" but I'm not 100% sure
> that this is the right thing to do in all cases.

The MS Doco for createMutex says that a default argument results in a
non inheritable mutex. so in theory, it's the right thing.
=20
> Could someone who is familiar with the code (Robert?, Thomas?) look
> at the patch below and, if I got it wrong, fix this so that the
> handles will be properly inherited, if required?

Please commit this.

Rob
--=20
---
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.
---

--=-6nqZQt1s18mjBAo6h45m
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQA9mLfXI5+kQ8LJcoIRAvw+AJ9r/J1ErmnQCf+aneY7owr92M0ZtwCdFKcA
lrZ4onYiiSE4/GX/giyd9bU=
=uoIN
-----END PGP SIGNATURE-----

--=-6nqZQt1s18mjBAo6h45m--