Mailing-List: contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT cygwin DOT com>
List-Help: <mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT cygwin DOT com
Delivered-To: mailing list cygwin-developers AT cygwin DOT com
Subject: Re: Recent change to init.cc for thread detach looks wrong?
From: Robert Collins <rbcollins AT cygwin DOT com>
To: Thomas Pfaff <tpfaff AT gmx DOT net>
Cc: cygwin-developers AT cygwin DOT com
In-Reply-To: <Pine.WNT.4.44.0209200938420.252-100000@algeria.intern.net>
References: <Pine DOT WNT DOT 4 DOT 44 DOT 0209200938420 DOT 252-100000 AT algeria DOT intern DOT net>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature";
	boundary="=-Yt3lLNLoVXiZruOIXvYl"
Date: 20 Sep 2002 22:56:25 +1000
Message-Id: <1032526586.9116.67.camel@lifelesswks>
Mime-Version: 1.0


--=-Yt3lLNLoVXiZruOIXvYl
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Fri, 2002-09-20 at 17:42, Thomas Pfaff wrote:
>=20
>=20
> On Fri, 20 Sep 2002, Robert Collins wrote:
>=20
> > On Fri, 2002-09-20 at 15:32, Christopher Faylor wrote:
> > > Robert,
> > > Your recent change:
> > > 2002-09-11  Robert Collins  <rbtcollins AT hotmail DOT com>
> > >
> > >         * init.cc (dll_entry): On thread detach, if the thread hasn't
> > >         exit()ed, do so.
> > >
> > > doesn't look right.  The code invokes pthread::exit which can block
> > > waiting on a mutex, it seems.
> >
> > Ok, will correct this weekend.
> >
>=20
> You may have a look at my pthread patch part 4 that shows how i
> have implemented cleanup after thread termination.

Ok, so this effectively calls pthread::~pthread, which closes the win32
objects, but does not set exit values etc.

Hmm, I need to look more closely.

lets try and get your patches in, rather than reinvent something.

Rob

--=-Yt3lLNLoVXiZruOIXvYl
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQA9ixr5I5+kQ8LJcoIRAlZ9AKCkgYPQgHwADqb9mqYssqON/YgLHQCeLNgk
sfPbZeWNVsHG4DSA1Wgq0JI=
=Qm3k
-----END PGP SIGNATURE-----

--=-Yt3lLNLoVXiZruOIXvYl--